fix data race error during env var cleanup #2509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Aug 26, 2022
fix data race error during env var cleanup Fixes #2508
|
💔 Test failed - checks-actions |
RalfJung
force-pushed
the
env-data-race
branch
from
228976f to
6084c7f
Compare
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Aug 26, 2022
fix data race error during env var cleanup Fixes #2508
|
💔 Test failed - checks-actions |
|
@oli-obk something odd is happening. I accidentally added a test that needs dependencies to the regular |
|
Oh, locally I don't have the patch yet that runs |
RalfJung
force-pushed
the
env-data-race
branch
from
6084c7f to
10a1a59
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2508