Add shims for file handling #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvdrz
commented
Sep 25, 2019
pvdrz
commented
Sep 25, 2019
pvdrz
commented
Sep 25, 2019
pvdrz
commented
Sep 25, 2019
oli-obk
reviewed
Sep 25, 2019
|
☔ The latest upstream changes (presumably #957) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
reviewed
Sep 30, 2019
oli-obk
reviewed
Sep 30, 2019
oli-obk
reviewed
Sep 30, 2019
oli-obk
reviewed
Sep 30, 2019
oli-obk
reviewed
Oct 1, 2019
pvdrz
commented
Oct 1, 2019
oli-obk
reviewed
Oct 1, 2019
|
@bors r+ |
|
📌 Commit d0509d7 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 1, 2019
Add shims for file handling This adds the bare minimum to be able to do `File::open` and `File::read`. I also need some feedback about how to handle certain things
|
☀️ Test successful - checks-travis, status-appveyor |
RalfJung
reviewed
Oct 10, 2019
RalfJung
reviewed
Oct 10, 2019
RalfJung
reviewed
Oct 10, 2019
RalfJung
reviewed
Oct 10, 2019
RalfJung
reviewed
Oct 10, 2019
RalfJung
reviewed
Oct 10, 2019
RalfJung
reviewed
Oct 10, 2019
RalfJung
reviewed
Oct 10, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the bare minimum to be able to do
File::openandFile::read. I also need some feedback about how to handle certain things