-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sample code with stable alloc crate #161
Conversation
1400bf8
to
eb154c0
Compare
self.ptr.as_ptr().offset(index as isize), | ||
self.len - index, | ||
); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you reformatting the code?
buf.ptr.as_ptr() | ||
} else { | ||
buf.ptr.as_ptr().offset(len as isize) | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure this is unnecessary, but it's fair this isn't documented properly.
a73218c
to
91582ca
Compare
@lzutao could you please also replace |
e4a3f8d
to
c34299f
Compare
@CreepySkeleton Thanks for the interest. |
@lzutao
AFAIK, that's all. As we can see, in this case |
ill close #182 as its a duplicate (although just covering all aspects of the vec example) but may be worth looking to see if theres anything worth adding from there. it would be good to merge in something like this, as i was not able to get any of the examples to compile on nightly and im sure others have the same problem. |
I have no interest in continuing this PR. |
Based on #170 .