Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enum documentation not updated for RFC 2195 #786

Closed
RalfJung opened this issue Apr 4, 2020 · 3 comments · Fixed by #879
Closed

enum documentation not updated for RFC 2195 #786

RalfJung opened this issue Apr 4, 2020 · 3 comments · Fixed by #879
Labels
A-type-layout Area: type layout

Comments

@RalfJung
Copy link
Member

RalfJung commented Apr 4, 2020

https://doc.rust-lang.org/reference/items/enumerations.html#custom-discriminant-values-for-field-less-enumerations talks about "Custom Discriminant Values for Field-Less Enumerations", but does not mention at all that since https://github.com/rust-lang/rfcs/blob/master/text/2195-really-tagged-unions.md Rust also supports custom discriminant values and defined layout for enums with fields.
@ehuss
Copy link
Contributor

ehuss commented Apr 4, 2020

It looks like there was an attempt to do this at #246 that wasn't completed.

@ehuss ehuss added the A-type-layout Area: type layout label Apr 4, 2020
@Havvy
Copy link
Contributor

Havvy commented Aug 19, 2020

cc-ing @poliorcetics as requested in Zulip.

@poliorcetics poliorcetics mentioned this issue Aug 21, 2020
Merged
@poliorcetics
Copy link
Contributor

Opened #879 to hopefully fix this.

@ehuss ehuss closed this as completed in #879 Sep 4, 2020
ehuss pushed a commit that referenced this issue Sep 4, 2020
@poliorcetics
Document the enum changes in RFC 2195 (#879)
66b4d58 
Document the changes introduced in https://github.com/rust-lang/rfcs/blob/master/text/2195-really-tagged-unions.md.

Fixes #244 (I believe), fixes #786.
ldm0 pushed a commit to ldm0/reference that referenced this issue Sep 16, 2020
@poliorcetics @ldm0
Document the enum changes in RFC 2195 (rust-lang#879)
200e1d3 
Document the changes introduced in https://github.com/rust-lang/rfcs/blob/master/text/2195-really-tagged-unions.md.

Fixes rust-lang#244 (I believe), fixes rust-lang#786.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-type-layout Area: type layout
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document the enum changes in RFC 2195
4 participants
@ehuss @RalfJung @Havvy @poliorcetics