Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide Self in record literal completion #12123

Merged
merged 1 commit into from
May 2, 2022

Conversation

yue4u
Copy link
Contributor

@yue4u yue4u commented Apr 30, 2022

close #12106

@bors
Copy link
Contributor

bors commented May 1, 2022

☔ The latest upstream changes (presumably #12118) made this pull request unmergeable. Please resolve the merge conflicts.

@yue4u yue4u force-pushed the feat/impl-self-completion branch from b5dc377 to f3e3abf Compare May 1, 2022 12:02
@Veykril
Copy link
Member

Veykril commented May 2, 2022

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented May 2, 2022

📌 Commit f3e3abf has been approved by Veykril

@bors
Copy link
Contributor

bors commented May 2, 2022

⌛ Testing commit f3e3abf with merge f83dccf...

@bors
Copy link
Contributor

bors commented May 2, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing f83dccf to master...

@bors bors merged commit f83dccf into rust-lang:master May 2, 2022
@lnicola
Copy link
Member

lnicola commented May 9, 2022

image

Hmm, are the trait names (Send) actually valid completions here?

@flodiebold
Copy link
Member

Trait names might be the beginning of an associated item path (method call or constant). Of course Send doesn't have any of those, so maybe we could remove it in expression context.

@lnicola
Copy link
Member

lnicola commented May 9, 2022

Ah, right, ToString::to_string(&x).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Struct literal completion should also suggest Self { ... } when in an impl
5 participants