Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::rt::task::TaskType fields made private, used in rust-mozjs #10065

Closed
SimonSapin opened this issue Oct 25, 2013 · 3 comments · Fixed by #10141
Closed

std::rt::task::TaskType fields made private, used in rust-mozjs #10065

SimonSapin opened this issue Oct 25, 2013 · 3 comments · Fixed by #10141

Comments

@SimonSapin
Copy link
Contributor

0ada7c7 made private the current_stack_segment field of std::rt::task::TaskType that is used by rust-mozjs’s rust.rs#L69.

Should this really be private? Or should rust-mozjs use something else? (I have no idea what this code is doing, I’m upgrading Rust-in-Servo to get an unrelated bug fix.)
@jdm
Copy link
Contributor

jdm commented Oct 25, 2013

I originally added this to the C++ runtime (and corresponding Rust types) in order to allow SpiderMonkey's garbage collection to see the bounds of Rust's stack. Exposing this information in some fashion is vital.

@alexcrichton
Copy link
Member

I think it's fine if these are made public again.

@brson
Copy link
Contributor

brson commented Oct 26, 2013

Yeah, it's fine for them to be public - whatever works for servo, as long as it's understood that std::rt is mostly unstable.

bors added a commit that referenced this issue Oct 29, 2013
@bors
auto merge of #10141 : kmcallister/rust/current_stack_segment, r=alex…
fc766ef 
…crichton

This was done in 2145de8 and reverted in 0ada7c7, but Servo needs it.

Closes #10065.

r? @brson
@bors bors closed this as completed in f6b236b Oct 29, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 17, 2022
@bors
Auto merge of rust-lang#10096 - feniljain:fix-seek-rewind, r=xFrednet
391b2a6 
fix: not suggest seek_to_start_instead_of_rewind when expr is used

changelog: [`seek_to_start_instead_of_rewind`]: No longer lints, if the return of `seek` is used.
[rust-lang#10096](rust-lang/rust-clippy#10096)
<!-- changelog_checked -->

Fixes rust-lang#10065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rt::task: Make current_stack_segment public again kmcallister/rust
4 participants
@jdm @alexcrichton @brson @SimonSapin