Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tests to be ignored conditionally #1049

Closed
brson opened this issue Oct 19, 2011 · 0 comments
Closed

Allow tests to be ignored conditionally #1049

brson opened this issue Oct 19, 2011 · 0 comments
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Oct 19, 2011

Right now we can ignore a test like

#[test]
#[ignore]
fn test() { /* do something */ }

But to ignore it only on windows you've got to do

#[test]
#[cfg(target_os = "win32")]
#[ignore]
fn test() { /* do nothing */ }

#[test]
#[cfg(target_os = "macos")]
#[cfg(target_os = "linux")]
fn test() { /* do something */ }

We should just be able to do this

#[test]
#[ignore(target_os = "win32")]
fn test() { /* do something */ }

Where the thing insider ignore() is just matched against all configuration items in the compilation environment

@brson brson closed this as completed Nov 7, 2011
bjorn3 added a commit to bjorn3/rust that referenced this issue Aug 6, 2021
Cranelift's fmin and fmax instructions propagate NaN, while Rust's min
and max don't.

Fixes rust-lang#1049
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

1 participant