Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLVM 18 issue: tests/codegen/pow_of_two.rs broken after https://github.com/rust-lang/rust/commit/9dccd5dce11f2fcce81fc77f4271eaf2359e2626 #120377

Closed
krasimirgg opened this issue Jan 26, 2024 · 1 comment · Fixed by #120376
Closed

LLVM 18 issue: tests/codegen/pow_of_two.rs broken after https://github.com/rust-lang/rust/commit/9dccd5dce11f2fcce81fc77f4271eaf2359e2626 #120377

krasimirgg opened this issue Jan 26, 2024 · 1 comment · Fixed by #120376
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug.

Comments

@krasimirgg
Copy link
Contributor

krasimirgg commented Jan 26, 2024 •
edited
Loading

Seems like the updated test expectations don't quite match up with LLVM 18, first failing check is:

 // CHECK: %{{[^ ]+}} = zext i32 %exp to i64

Found over at our experimental rust + LLVM @ HEAD build bot:
https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/25504#018d4612-a220-458b-84c9-1d8f56b6fbde/724-725

Looks like LLVM 18 adds some extra nneg-s, testing a PR to fix this: #120380
@krasimirgg krasimirgg added the C-bug Category: This is a bug. label Jan 26, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 26, 2024
@krasimirgg
Copy link
Contributor Author

@rustbot label: +A-LLVM

@rustbot rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Jan 26, 2024
krasimirgg added a commit to krasimirgg/rust that referenced this issue Jan 26, 2024
@krasimirgg
adapt tests/codegen/pow_of_two.rs for LLVM 18
4c37367 
Fixes rust-lang#120377.
@krasimirgg krasimirgg mentioned this issue Jan 26, 2024
Closed
@cuviper cuviper linked a pull request Jan 26, 2024 that will close this issue
Update codegen test for LLVM 18 #120376
Merged
@saethlin saethlin added A-testsuite Area: The testsuite used to check the correctness of rustc and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
3 participants
@saethlin @krasimirgg @rustbot