Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs #129163

Closed
tgross35 opened this issue Aug 16, 2024 · 3 comments · Fixed by #129190
Closed

Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs #129163

tgross35 opened this issue Aug 16, 2024 · 3 comments · Fixed by #129190
Assignees
@rezwanahmedsami
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]`

Comments

@tgross35
Copy link
Contributor

tgross35 commented Aug 16, 2024 •
edited by rustbot
Loading

This file is only f32 and f64: https://github.com/rust-lang/rust/blob/a73bc4a131d94eba633c4c572a28e0bf94a67530/tests/ui/consts/const-float-bits-conv.rs, but we should add the other float types to this test.

The change should wait for #128598 since that changes some of these semantics (this PR is almost merged).

There are probably a handful of tests that only check f32 and f64 but could use updates with the new types.
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 16, 2024
@tgross35 tgross35 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 16, 2024
@rezwanahmedsami
Copy link
Contributor

Okay will do that

@tgross35
Copy link
Contributor Author

FYI you can comment @rustbot claim to assign yourself an issue

@rezwanahmedsami
Copy link
Contributor

@rustbot claim

@rezwanahmedsami rezwanahmedsami mentioned this issue Aug 17, 2024
Merged
tgross35 added a commit to tgross35/rust that referenced this issue Aug 17, 2024
@tgross35
Rollup merge of rust-lang#129190 - rezwanahmedsami:master, r=tgross35

Verified

This commit was signed with the committer’s verified signature.
vlad20012 Vlad Beskrovny
GPG key ID: 58E62ED31A8B3999
Verified
Learn about vigilant mode
b657787 
Added f16 and f128 to tests/ui/consts/const-float-bits-conv.rs

 Fixes rust-lang#129163
bors added a commit to rust-lang-ci/rust that referenced this issue Aug 18, 2024
@bors
Auto merge of rust-lang#129190 - rezwanahmedsami:master, r=<try>

Verified

This commit was signed with the committer’s verified signature.
vlad20012 Vlad Beskrovny
GPG key ID: 58E62ED31A8B3999
Verified
Learn about vigilant mode
Loading
Loading status checks…
28f80c7 
Added f16 and f128 to tests/ui/consts/const-float-bits-conv.rs

Fixes rust-lang#129163

try-job: x86_64-msvc
try-job: x86_64-mingw
try-job: i686-msvc
try-job: i686-mingw
jieyouxu added a commit to jieyouxu/rust that referenced this issue Aug 20, 2024
@jieyouxu
Rollup merge of rust-lang#129190 - rezwanahmedsami:master, r=tgross35

Verified

This commit was signed with the committer’s verified signature.
vlad20012 Vlad Beskrovny
GPG key ID: 58E62ED31A8B3999
Verified
Learn about vigilant mode
cf5dcd2 
Added f16 and f128 to tests/ui/consts/const-float-bits-conv.rs

Fixes rust-lang#129163

try-job: x86_64-msvc
try-job: x86_64-mingw
try-job: i686-msvc
try-job: i686-mingw
jieyouxu added a commit to jieyouxu/rust that referenced this issue Aug 20, 2024
@jieyouxu
Rollup merge of rust-lang#129190 - rezwanahmedsami:master, r=tgross35

Verified

This commit was signed with the committer’s verified signature.
vlad20012 Vlad Beskrovny
GPG key ID: 58E62ED31A8B3999
Verified
Learn about vigilant mode
acc9752 
Added f16 and f128 to tests/ui/consts/const-float-bits-conv.rs

Fixes rust-lang#129163

try-job: x86_64-msvc
try-job: x86_64-mingw
try-job: i686-msvc
try-job: i686-mingw
tgross35 added a commit to tgross35/rust that referenced this issue Aug 21, 2024
@tgross35
Rollup merge of rust-lang#129190 - rezwanahmedsami:master, r=tgross35
61cc570 
Added f16 and f128 to tests/ui/consts/const-float-bits-conv.rs

Fixes rust-lang#129163

try-job: x86_64-msvc
try-job: x86_64-mingw
try-job: i686-msvc
try-job: i686-mingw
jieyouxu added a commit to jieyouxu/rust that referenced this issue Aug 22, 2024
@jieyouxu
Rollup merge of rust-lang#129190 - rezwanahmedsami:master, r=tgross35
b79cc36 
Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs

Fixes rust-lang#129163

try-job: x86_64-msvc
try-job: x86_64-mingw
try-job: i686-msvc
try-job: i686-mingw
tgross35 added a commit to tgross35/rust that referenced this issue Aug 22, 2024
@tgross35
Rollup merge of rust-lang#129190 - rezwanahmedsami:master, r=tgross35
d3d65dc 
Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs

Fixes rust-lang#129163

try-job: x86_64-msvc
try-job: x86_64-mingw
try-job: i686-msvc
try-job: i686-mingw
tgross35 added a commit to tgross35/rust that referenced this issue Aug 23, 2024
@tgross35
Rollup merge of rust-lang#129190 - rezwanahmedsami:master, r=tgross35
42e8972 
Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs

Fixes rust-lang#129163

try-job: x86_64-msvc
try-job: x86_64-mingw
try-job: i686-msvc
try-job: i686-mingw
jieyouxu added a commit to jieyouxu/rust that referenced this issue Aug 23, 2024
@jieyouxu
Rollup merge of rust-lang#129190 - rezwanahmedsami:master, r=tgross35
b07a988 
Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs

Fixes rust-lang#129163

try-job: x86_64-msvc
try-job: x86_64-mingw
try-job: i686-msvc
try-job: i686-mingw
jieyouxu added a commit to jieyouxu/rust that referenced this issue Aug 23, 2024
@jieyouxu
Rollup merge of rust-lang#129190 - rezwanahmedsami:master, r=tgross35
5438d97 
Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs

Fixes rust-lang#129163

try-job: x86_64-msvc
try-job: x86_64-mingw
try-job: i686-msvc
try-job: i686-mingw
tgross35 added a commit to tgross35/rust that referenced this issue Aug 25, 2024
@tgross35
Rollup merge of rust-lang#129190 - rezwanahmedsami:master, r=tgross35
520ed56 
Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs

Fixes rust-lang#129163

try-job: x86_64-msvc
try-job: x86_64-mingw
try-job: i686-msvc
try-job: i686-mingw
@bors bors closed this as completed in dedfb35 Aug 26, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Aug 26, 2024
@rust-timer
Unrolled build for rust-lang#129190
Loading
Loading status checks…
011e2d1 
Rollup merge of rust-lang#129190 - rezwanahmedsami:master, r=tgross35

Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs

Fixes rust-lang#129163

try-job: x86_64-msvc
try-job: x86_64-mingw
try-job: i686-msvc
try-job: i686-mingw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rezwanahmedsami rezwanahmedsami

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]`
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add f16 and f128 to tests/ui/consts/const-float-bits-conv.rs rezwanahmedsami/rust
3 participants
@tgross35 @rustbot @rezwanahmedsami