Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'make dist' doesn't work correctly on mac #13224

Closed
brson opened this issue Mar 31, 2014 · 5 comments
Closed

'make dist' doesn't work correctly on mac #13224

brson opened this issue Mar 31, 2014 · 5 comments
Labels
O-macos Operating system: macOS

Comments

@brson
Copy link
Contributor

brson commented Mar 31, 2014

We use the --exclude-vcs flag to tar, which doesn't exist on Mac. I'm temorarily going to change the dist target to not produce tarballs on Mac to work around the problem on our nightly builders.
brson added a commit to brson/rust that referenced this issue Mar 31, 2014
@brson
mk: Workaround distcheck failure on mac. rust-lang#13224
d2686c7 
Mac can't actually build our source tarballs because it's `tar`
command doesn't support the --exclude-vcs flag. This is just
a workaround to make our mac nightlies work (we get our source
tarballs from the linux bot).
@flaper87
Copy link
Contributor

Triage bump: I don't have a way to verify this but the workaround is still there.

@steveklabnik steveklabnik added the O-macos Operating system: macOS label Feb 16, 2015
@steveklabnik
Copy link
Member

triage: i don't own a mac either. @brson is this part of rust-installer now?

@frewsxcv
Copy link
Member

I can confirm that the conditional added in d2686c7 still exists currently:

https://github.com/brson/rust/blob/1d00c545ede609b9d43fdf9f252c15da5a66dac7/mk/dist.mk#L256-L261

Considering all --exclude-vcs does is ignore version control related software, one potential fix for this would be to use --exclude .git --exclude .gitmodules --exclude .gitignore which AFAIK works with both BSD and GNU tar

@steveklabnik
Copy link
Member

Triage: still there today

rust/mk/dist.mk

Lines 352 to 357 in 8f62c29

# FIXME #13224: On OS X don't produce tarballs simply because --exclude-vcs don't work.
# This is a huge hack because I just don't have time to figure out another solution.
ifeq ($(CFG_OSTYPE), apple-darwin)
MAYBE_DIST_TAR_SRC=
MAYBE_DISTCHECK_TAR_SRC=
endif

@alexcrichton
Copy link
Member

Make's now gone, so closing.

(fixed in rustbulid)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-macos Operating system: macOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@flaper87 @steveklabnik @alexcrichton @brson @frewsxcv and others