build error: generated a symlink in a tarball

[bryteise]

When building rust-1.84.0 from the source tarball on Linux I'm seeing the following in a backtrace:

thread 'main' panicked at src/utils/tarball.rs:397:21: generated a symlink in a tarball: /builddir/build/BUILD/rustc-1.84.0-src/build/tmp/tarball/rustc/x86_64-unknown-linux-gnu/rustc-1.84.0-x86_64-unknown-linux-gnu/rustc/lib/rustlib/x86_64-unknown-linux-gnu/bin/rust-objcopy

My config.toml has the following:

profile = "dist"
[llvm]
link-shared = true
download-ci-llvm = false
[build]
target = [
  "x86_64-unknown-linux-gnu",
  "i686-unknown-linux-gnu",
]
cargo = "/usr/bin/cargo"
rustc = "/usr/bin/rustc"
rustfmt = "/usr/bin/rustfmt"
locked-deps = true
vendor = true
tools = ["cargo", "clippy", "rustdoc", "rustfmt"]
sanitizers = true
profiler = true
docs = false
[install]
prefix = "/usr"
[rust]
codegen-units-std = 1
debuginfo-level = 1
debuginfo-level-std = 2
channel = "stable"
description = ""
rpath = false
frame-pointers = true
lld = false
use-lld = "external"
llvm-bitcode-linker = false
deny-warnings = false
backtrace-on-ice = true
remap-debuginfo = false
jemalloc = true
# codegen-tests depend on LLVM utils (FileCheck) we don't provide
codegen-tests = false

Looking at another issue I tried llvm-tools = false and hit a different issue:

src.symlink_metadata() failed with No such file or directory (os error 2) ("src = /builddir/build/BUILD/rustc-1.84.0-src/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/bin/llvm-objcopy")

I'm inclined to just patch out the test for the symlink in the tarfile for now as that appears to be only there because of windows but this seems like a problem regardless.

[onur-ozkan]

We should resolve symlinks before adding them to tarballs. I plan to submit a PR for this in a few hours.

[onur-ozkan]

You can cherry-pick #135585 until we backport it into the stable release.

[bryteise]

Thanks!