-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: missing type parameters on impls of generic traits #14508
Comments
Dup of #14462 |
@sfackler Are you sure this is a dup? It doesn't seem covered by the issue you referenced. |
Isn't this the first bullet? ("Lifetime parameters on functions are missing") |
Although that other issue may only explicitly cover the trait itself, not the impls. |
No -- I was referring to the line that says what trait is being implemented. Currently, for
but you should get
These are regular type parameters to the trait itself, not lifetime parameters on a function. |
Oh! |
This is quite unusual. I will investigate. |
I have a fix, will open a PR soon with some other improvements. |
Type parameters were filled in for some areas, but not all. This commit unifies the two code paths to fill in type parameters everywhere. Closes rust-lang#14508
Sometimes, but not always, rustdoc does not record the type parameters for a trait impl.
For example, the
Rc
type (http://static.rust-lang.org/doc/master/std/rc/struct.Rc.html) correctly shows the type parameter for theHash
impl but does not show it forDeref
impl.The text was updated successfully, but these errors were encountered: