Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dist analysis step panics when trying to copy save-analysis #61703

Closed
petrhosek opened this issue Jun 9, 2019 · 1 comment · Fixed by #61750
Closed

Dist analysis step panics when trying to copy save-analysis #61703

petrhosek opened this issue Jun 9, 2019 · 1 comment · Fixed by #61750

Comments

@petrhosek
Copy link
Contributor

We're seeing the following error on our builders that are building Rust toolchain for Fuchsia:

Dist analysis
image_src: "/b/s/w/ir/k/recipe_cleanup/rust9mc0u9/build/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/save-analysis", dst: "/b/s/w/ir/k/recipe_cleanup/rust9mc0u9/build/build/tmp/dist/rust-analysis-nightly-x86_64-unknown-linux-gnu-image/lib/rustlib/x86_64-unknown-linux-gnu/analysis"
thread 'main' panicked at 'fs::read_dir(src) failed with No such file or directory (os error 2)', src/bootstrap/lib.rs:1217:18

The save-analysis directory is entirely missing for the host target. I've been debugging this and I believe the problem is that for host target, we don't build std in stage2, we always uplift it from stage1, and therefore we never generate save-analysis in stage2. We should probably uplift save-analysis from stage1 as well.
@Mark-Simulacrum
Copy link
Member

Seems reasonable, I think - happy to review a PR or if you could give a specific set of reproduction instructions (ideally ones that would work on linux).

@tmandry tmandry mentioned this issue Jun 11, 2019
Merged
tmandry added a commit to tmandry/rust that referenced this issue Jun 11, 2019
@tmandry
Fix x.py install
4f3cd3c 
Make sure we look for save analysis in the right place. Fixes rust-lang#61703.
Centril added a commit to Centril/rust that referenced this issue Jun 12, 2019
@Centril
Rollup merge of rust-lang#61750 - tmandry:fix-install, r=Mark-Simulacrum
d61e2f2 
Fix x.py install

Make sure we look for save analysis in the right place. Fixes rust-lang#61703.

r? @Mark-Simulacrum
cc @petrhosek @cramertj
Centril added a commit to Centril/rust that referenced this issue Jun 12, 2019
@Centril
Rollup merge of rust-lang#61750 - tmandry:fix-install, r=Mark-Simulacrum
4cbae09 
Fix x.py install

Make sure we look for save analysis in the right place. Fixes rust-lang#61703.

r? @Mark-Simulacrum
cc @petrhosek @cramertj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix x.py install tmandry/rust
2 participants
@petrhosek @Mark-Simulacrum