Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for std::io::{BufReader, BufWriter}::capacity #68833

Closed
JohnTitor opened this issue Feb 4, 2020 · 6 comments · Fixed by #72924
Closed

Tracking issue for std::io::{BufReader, BufWriter}::capacity #68833

JohnTitor opened this issue Feb 4, 2020 · 6 comments · Fixed by #72924
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@JohnTitor
Copy link
Member

#68558 adds capacity methods to BufReader and BufWriter.

Unresolved questions:
@jonas-schievink jonas-schievink added B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Feb 4, 2020
@JohnTitor JohnTitor mentioned this issue Feb 4, 2020
Merged
@mbrubeck
Copy link
Contributor

mbrubeck commented May 8, 2020

Can I nominate this for stabilization? It's a straightforward API with no real alternatives possible, and I had a real-world use case for it recently.

@JohnTitor
Copy link
Member Author

CC @rust-lang/libs --^?

@sfackler
Copy link
Member

sfackler commented May 8, 2020

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented May 8, 2020 •
edited by Amanieu
Loading

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels May 8, 2020
@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label May 23, 2020
@rfcbot
Copy link

rfcbot commented May 23, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label May 23, 2020
@rfcbot
Copy link

rfcbot commented Jun 2, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jun 2, 2020
@JohnTitor JohnTitor mentioned this issue Jun 2, 2020
Merged
@bors bors closed this as completed in ec2826c Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize std::io::Buf{Reader, Writer}::capacity JohnTitor/rust
5 participants
@mbrubeck @sfackler @jonas-schievink @rfcbot @JohnTitor