Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy-driver no longer builds after rust-lang/rust#69366 #69419

Closed
rust-highfive opened this issue Feb 24, 2020 · 1 comment · Fixed by #69421
Closed

clippy-driver no longer builds after rust-lang/rust#69366 #69419

rust-highfive opened this issue Feb 24, 2020 · 1 comment · Fixed by #69421
Assignees
@oli-obk @Manishearth @yaahc @phansch @mcarton @llogiq @flip1995
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #69366, I observed that the tool clippy-driver no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rust-clippy is needed to fix the fallout.

cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @petrochenkov, the PR reviewer, and nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 24, 2020
@flip1995 flip1995 mentioned this issue Feb 24, 2020
Merged
@petrochenkov
Copy link
Contributor

[triagebot] I never answer to pings from issues like this because they are routinely fixed by people working on the affected tools.

@rust-highfive shouldn't ping the reviewer in general.
If there are issues with a tool upgrade, then ping can happen on the tool upgrade attempt PR.

bors added a commit that referenced this issue Feb 24, 2020
@bors
Auto merge of #69421 - flip1995:clippyup, r=Dylan-DPC
2f1aec9 
Update Clippy from 8fbb23f to fc5d0cc

Fixes #69419

```
Fix false positive in `missing_const_for_fn`
Rustup to #69366
Add new lint [`wildcard imports`]. Add suggestion to [`enum_glob_use`]
Add new lint `lossy_float_literal` to detect lossy whole number float literals
```
@JohnTitor JohnTitor mentioned this issue Feb 25, 2020
Merged
@bors bors closed this as completed in 6fd8798 Feb 25, 2020
@petrochenkov petrochenkov mentioned this issue Feb 26, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Feb 27, 2020
@Dylan-DPC
Rollup merge of rust-lang#69449 - JohnTitor:toolstate-ping, r=Mark-Si…
7a92149 
…mulacrum

Do not ping PR reviewers in toolstate breakage

As per rust-lang#69419 (comment)

We should also remove author part?
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Feb 28, 2020
@Dylan-DPC
Rollup merge of rust-lang#69449 - JohnTitor:toolstate-ping, r=Mark-Si…
ab45408 
…mulacrum

Do not ping PR reviewers in toolstate breakage

As per rust-lang#69419 (comment)

We should also remove author part?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oli-obk oli-obk

@Manishearth Manishearth

@yaahc yaahc

@phansch phansch

@mcarton mcarton

@llogiq llogiq

@flip1995 flip1995

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Clippy from 8fbb23f to fc5d0cc flip1995/rust
9 participants
@oli-obk @Manishearth @yaahc @phansch @mcarton @llogiq @petrochenkov @rust-highfive @flip1995