Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustdoc doesn't display the align component of #[repr(C, align(N))] #69559

Closed
sfackler opened this issue Feb 28, 2020 · 0 comments · Fixed by #69686
Closed

Rustdoc doesn't display the align component of #[repr(C, align(N))] #69559

sfackler opened this issue Feb 28, 2020 · 0 comments · Fixed by #69686
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@sfackler
Copy link
Member

For example, AtomicU64 is #[repr(C, align(8))], but rustdoc just displays #[repr(C)]: https://doc.rust-lang.org/std/sync/atomic/struct.AtomicU64.html
@sfackler sfackler added C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 28, 2020
@varkor varkor mentioned this issue Mar 4, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Mar 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#69686 - varkor:rustdoc-attributes, r=Guilla…
a338c0e 
…umeGomez

Use `pprust` to print attributes in rustdoc

Fixes rust-lang#69559.

I'm not sure what the original motivation was for the `render_attribute`, so I may be missing something, but replacing it with `pprust::attribute_to_string` seems to give the intended output (modulo some spacing idiosyncrasies).

r? @GuillaumeGomez
@bors bors closed this as completed in e5de0b1 Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use pprust to print attributes in rustdoc varkor/rust
1 participant
@sfackler