Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstable (de facto internal) library feature gen_future links to a closed tracking issue (for async/await) #76249

Closed
ArekPiekarz opened this issue Sep 2, 2020 · 6 comments
Closed

Unstable (de facto internal) library feature gen_future links to a closed tracking issue (for async/await) #76249

ArekPiekarz opened this issue Sep 2, 2020 · 6 comments
Assignees
@progressive-galib
Labels
A-async-await Area: Async & Await A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@ArekPiekarz
Copy link
Contributor

ArekPiekarz commented Sep 2, 2020 •
edited by rustbot
Loading

Unstable Book in section gen_future leads to a closed tracking issue #50547 titled Tracking issue for async/await (RFC 2394).

There are a few solutions to this:
- reopen the tracking issue, or
- create a new tracking issue and a PR updating the issue number in documentation, or
- mark the feature as internal only, or
- something else?
@camelid camelid added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Oct 20, 2020
@fmease fmease added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 11, 2025
@fmease fmease changed the title Unstable Book: "gen_future" leads to a closed tracking issue Unstable library feature gen_future links to a closed tracking issue (for async/await) Feb 11, 2025
@fmease fmease added A-async-await Area: Async & Await E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Feb 11, 2025
@fmease fmease changed the title Unstable library feature gen_future links to a closed tracking issue (for async/await) Unstable (de facto internal) library feature gen_future links to a closed tracking issue (for async/await) Feb 11, 2025
@fmease
Copy link
Member

fmease commented Feb 11, 2025

This is a de facto internal library feature that gates the internal ResumeTy & get_context used in the desugaring of async blocks as far as I can tell.

The solution is easy, simply replace the four occurrences of issue = "50547" in library/core/src/future/mod.rs with issue = "none". This way, the Unstable Book will automatically switch to the synopsis “This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.”.

@progressive-galib progressive-galib mentioned this issue Feb 15, 2025
Merged
@progressive-galib
Copy link
Contributor

@fmease done

@progressive-galib
Copy link
Contributor

progressive-galib commented Feb 15, 2025 •
edited
Loading

@rustbot claim

jhpratt added a commit to jhpratt/rust that referenced this issue Feb 24, 2025
@jhpratt
Rollup merge of rust-lang#137061 - progressive-galib:gen_future-closi…
b7f11ef 
…ng#76249, r=ibraheemdev

Unstable `gen_future` Feature Tracking

This PR removes the reference to the closed tracking issue **rust-lang#50547** for the `gen_future` feature. Since `gen_future` is an internal feature used in async block desugaring, it does not require a public tracking issue.

#### Changes:
- Replaced `issue = "50547"` with `issue = "none"` in **library/core/src/future/mod.rs**.
- Ensures that it is correctly identified as an internal feature.

#### Rationale:
With this change, the Unstable Book will now state:
> *"This feature has no tracking issue and is therefore likely internal to the compiler, not being intended for general use."*

Closes **rust-lang#76249**. 🚀🦀
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Feb 24, 2025
@rust-timer
Unrolled build for rust-lang#137061
4de6256 
Rollup merge of rust-lang#137061 - progressive-galib:gen_future-closing#76249, r=ibraheemdev

Unstable `gen_future` Feature Tracking

This PR removes the reference to the closed tracking issue **rust-lang#50547** for the `gen_future` feature. Since `gen_future` is an internal feature used in async block desugaring, it does not require a public tracking issue.

#### Changes:
- Replaced `issue = "50547"` with `issue = "none"` in **library/core/src/future/mod.rs**.
- Ensures that it is correctly identified as an internal feature.

#### Rationale:
With this change, the Unstable Book will now state:
> *"This feature has no tracking issue and is therefore likely internal to the compiler, not being intended for general use."*

Closes **rust-lang#76249**. 🚀🦀
@progressive-galib
Copy link
Contributor

@rustbot close

@rustbot
Copy link
Collaborator

rustbot commented Feb 24, 2025

Error: The feature close is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@fmease
Copy link
Member

fmease commented Feb 24, 2025

@progressive-galib FYI, in your PR #137061, GitHub likely did not recognize the "Closes …" as a keyword because you surrounded the issue hashtag with asterisks.

Closing as resolved by #137061.

@fmease fmease closed this as completed Feb 24, 2025
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this issue Mar 11, 2025
@jhpratt
Rollup merge of rust-lang#137061 - progressive-galib:gen_future-closi…
d301b90 
…ng#76249, r=ibraheemdev

Unstable `gen_future` Feature Tracking

This PR removes the reference to the closed tracking issue **rust-lang#50547** for the `gen_future` feature. Since `gen_future` is an internal feature used in async block desugaring, it does not require a public tracking issue.

#### Changes:
- Replaced `issue = "50547"` with `issue = "none"` in **library/core/src/future/mod.rs**.
- Ensures that it is correctly identified as an internal feature.

#### Rationale:
With this change, the Unstable Book will now state:
> *"This feature has no tracking issue and is therefore likely internal to the compiler, not being intended for general use."*

Closes **rust-lang#76249**. 🚀🦀
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this issue Mar 11, 2025
@jhpratt
Rollup merge of rust-lang#137061 - progressive-galib:gen_future-closi…
e63e6ce 
…ng#76249, r=ibraheemdev

Unstable `gen_future` Feature Tracking

This PR removes the reference to the closed tracking issue **rust-lang#50547** for the `gen_future` feature. Since `gen_future` is an internal feature used in async block desugaring, it does not require a public tracking issue.

#### Changes:
- Replaced `issue = "50547"` with `issue = "none"` in **library/core/src/future/mod.rs**.
- Ensures that it is correctly identified as an internal feature.

#### Rationale:
With this change, the Unstable Book will now state:
> *"This feature has no tracking issue and is therefore likely internal to the compiler, not being intended for general use."*

Closes **rust-lang#76249**. 🚀🦀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@progressive-galib progressive-galib

Labels
A-async-await Area: Async & Await A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ArekPiekarz @fmease @camelid @rustbot @progressive-galib