Use the power of adding helper function to simplify code w/ Mutability
#104786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in need_type_info.rs cc @lcnr |
rust-cloud-vms
bot
force-pushed
the
amp-mut-help
branch
from
1aae945 to
83fac06
Compare
|
Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
rust-cloud-vms
bot
force-pushed
the
amp-mut-help
branch
3 times, most recently
from
4a05732 to
7d555e1
Compare
rust-cloud-vms
bot
force-pushed
the
amp-mut-help
branch
from
7d555e1 to
967c07d
Compare
|
I'm fine with these changes, but I think that |
|
@compiler-errors I do think that it's much nicer that way, matching tends to be too verbose IMO. But I can revert that commit. |
|
I'd prefer if you did -- since it's only used in a handful of places, I'm not convinced it's as much of an ergonomic improvement compared to the other improvements in this commit stack. |
Comment on lines
1784
to
1787
| TyKind::Rptr(_, mt) if mt.ty.kind.is_implicit_self() && mt.mutbl.is_mut() => { | ||
| hir::ImplicitSelfKind::MutRef | ||
| } | ||
| TyKind::Rptr(_, mt) if mt.ty.kind.is_implicit_self() => { |
There was a problem hiding this comment.
Can you match or if on mt.mutbl here instead of doing this in two arms?
rust-cloud-vms
bot
force-pushed
the
amp-mut-help
branch
from
967c07d to
fddf7f4
Compare
rust-cloud-vms
bot
force-pushed
the
amp-mut-help
branch
from
fddf7f4 to
5503190
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 26, 2022
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#104786 (Use the power of adding helper function to simplify code w/ `Mutability`) - rust-lang#104788 (Do not record unresolved const vars in generator interior) - rust-lang#104909 (Rename `normalize_opaque_types` to `reveal_opaque_types_in_bounds`) - rust-lang#104921 (Remove unnecessary binder from `get_impl_future_output_ty`) - rust-lang#104924 (jsondoclint: Accept trait alias is places where trait expected.) - rust-lang#104928 (rustdoc: use flexbox CSS to align sidebar button instead of position) - rust-lang#104943 (jsondoclint: Handle using enum variants and glob using enums.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bjorn3
pushed a commit
to bjorn3/rust
that referenced
this pull request
Dec 14, 2022
…ler-errors Use the power of adding helper function to simplify code w/ `Mutability` r? `@compiler-errors`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @compiler-errors