Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an ICE parsing a malformed literal in concat_bytes!. #105039

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Fix an ICE parsing a malformed literal in concat_bytes!. #105039

merged 1 commit into from
Nov 30, 2022

Conversation

nnethercote
Copy link
Contributor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 29, 2022
jyn514
jyn514 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe name the test something more descriptive than issue-XXXXX?

@petrochenkov
Copy link
Contributor

r=me after renaming the test as jyn514 suggests and moving it from ui/parser to ui/macros.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2022
@nnethercote
Copy link
Contributor Author

I renamed the test.

@bors r=petrochenkov rollup

@bors
Copy link
Contributor

bors commented Nov 30, 2022

📌 Commit bf4a62c has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 30, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 30, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2022
@bors
Auto merge of rust-lang#105080 - matthiaskrgr:rollup-7ffj4oe, r=matth…
a569a88 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#104697 (Restore control flow on error in EUV)
 - rust-lang#104811 (feat: implement TcpStream shutdown for wasm32-wasi)
 - rust-lang#105039 (Fix an ICE parsing a malformed literal in `concat_bytes!`.)
 - rust-lang#105071 (Add Nicholas Nethercote to `.mailmap`.)
 - rust-lang#105079 (Add bots to `.mailmap`)

Failed merges:

 - rust-lang#105074 (Add Nicholas Bishop to `.mailmap`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 084bbcc into rust-lang:master Nov 30, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 30, 2022
@nnethercote nnethercote deleted the fix-104769 branch November 30, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 approved these changes

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

ICE: unreachable match arm in concat_bytes::invalid_type_err
5 participants
@nnethercote @petrochenkov @bors @jyn514 @rustbot