Shrink ParseResult in the hot path.

[Noratrieb]

#105570 increased the size, which caused regressions. This uses the existing generic infrastructure to differentiate between the hot path and the diagnostics path.

[rustbot]

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

[Noratrieb]

@bors try @rust-timer queue

[bors]

⌛ Trying commit b755a2a024f074d0b7607230d330285010170acc with merge 1959a379a1831b2a5888fa77f28c3b521807711b...

[bors]

☀️ Try build successful - checks-actions
Build commit: 1959a379a1831b2a5888fa77f28c3b521807711b (1959a379a1831b2a5888fa77f28c3b521807711b)

[bors]

☀️ Try build successful - checks-actions
Build commit: 1959a379a1831b2a5888fa77f28c3b521807711b (1959a379a1831b2a5888fa77f28c3b521807711b)

[rust-timer]

Finished benchmarking commit (1959a379a1831b2a5888fa77f28c3b521807711b): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.4%]	4
Improvements ✅ (secondary)	-0.7%	[-1.6%, -0.4%]	5
All ❌✅ (primary)	-0.5%	[-0.5%, -0.4%]	4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.9%	[-4.9%, -4.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.9%	[-4.9%, 1.1%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.5%	[-1.5%, -1.5%]	1
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-1.5%	[-1.5%, -1.5%]	1

[compiler-errors]

r=me with nit

[compiler-errors]

Wonderful

@bors r+

[bors]

📌 Commit 5112f02 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 5112f02 with merge b85f57d...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing b85f57d to master...

[rust-timer]

Finished benchmarking commit (b85f57d): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-0.4%	[-0.5%, -0.3%]	7
Improvements ✅ (secondary)	-0.4%	[-0.5%, -0.4%]	4
All ❌✅ (primary)	-0.4%	[-0.5%, -0.3%]	7

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.0%	[-3.1%, -3.0%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.0%	[-3.1%, -3.0%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

[compiler-errors]

I'm tempted to say that the single secondary regression is noise...

[Noratrieb]

I would think so.

[Mark-Simulacrum]

Improvements include primary benchmarks and outweigh regressions, though it seems like the regression is above the noise level.