Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unreachable error code E0490 #106714

Merged
merged 1 commit into from
Jan 12, 2023
Merged

remove unreachable error code E0490 #106714

merged 1 commit into from
Jan 12, 2023

Conversation

Ezrashaw
Copy link
Contributor

AFAIK, the untested and undocumented error code E0490 is now unreachable, it was from the days of the original borrow checker.

cc @GuillaumeGomez #61137

@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 11, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2023

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@Ezrashaw
Copy link
Contributor Author

I think @petrochenkov is taking a break from reviewing?

r? rust-lang/compiler

@rustbot rustbot assigned wesleywiser and unassigned petrochenkov Jan 11, 2023
davidtwco
davidtwco reviewed Jan 11, 2023
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after comment removed

@davidtwco
Copy link
Member

r? @davidtwco

@rustbot rustbot assigned davidtwco and unassigned wesleywiser Jan 11, 2023
@Ezrashaw Ezrashaw force-pushed the remove-e0490 branch 2 times, most recently from 2a0cff5 to 46d54de Compare January 12, 2023 01:09
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jan 12, 2023
@Ezrashaw
Copy link
Contributor Author

@davidtwco I've fixed the comment, took a while (CI seems to hate me today).

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 12, 2023

📌 Commit 02005e9 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2023
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Jan 12, 2023
@Noratrieb
Rollup merge of rust-lang#106714 - Ezrashaw:remove-e0490, r=davidtwco
4a0626e 
remove unreachable error code `E0490`

AFAIK, the untested and undocumented error code `E0490` is now unreachable, it was from the days of the original borrow checker.

cc `@GuillaumeGomez` rust-lang#61137
This was referenced Jan 12, 2023
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 12, 2023
@bors
Auto merge of rust-lang#106773 - Nilstrieb:rollup-sq73pyg, r=Nilstrieb
1bc3683 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#105806 (Support eager subdiagnostics again)
 - rust-lang#106322 (Handle inference variables in `CollectAllMismatches` correctly)
 - rust-lang#106579 (Suggest making private tuple struct field public)
 - rust-lang#106714 (remove unreachable error code `E0490`)
 - rust-lang#106751 (Fix rendering 'const' in header for intrinsics)
 - rust-lang#106761 (Add `WaffleLapkin` to compiler reviewers)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c61f29c into rust-lang:master Jan 12, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 12, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 14, 2023
Closed
100 tasks
@Ezrashaw Ezrashaw deleted the remove-e0490 branch January 16, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Ezrashaw @rustbot @davidtwco @bors @wesleywiser @petrochenkov