Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove various double spaces in the libraries. #106860

Merged
merged 2 commits into from
Jan 15, 2023
Merged

Remove various double spaces in the libraries. #106860

merged 2 commits into from
Jan 15, 2023

Conversation

anden3
Copy link
Contributor

@anden3 anden3 commented Jan 14, 2023

I was just pretty bothered by this when reading the source for a function, and was suggested to check if this happened elsewhere.

@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 14, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@anden3
Copy link
Contributor Author

anden3 commented Jan 14, 2023

cc @Dylan-DPC

@matthiaskrgr
Copy link
Member

Should probably be squashed into a single commit, removing two spaces per commit seems kind of underkill

@anden3
Copy link
Contributor Author

anden3 commented Jan 14, 2023 •
edited
Loading

Should probably be squashed into a single commit, removing two spaces per commit seems kind of underkill

Agreed, will squash before merging.

@Dylan-DPC
Copy link
Member

r? @Dylan-DPC

@rustbot rustbot assigned Dylan-DPC and unassigned m-ou-se Jan 14, 2023
@anden3 anden3 force-pushed the doc-double-spaces branch from 2624a25 to 0b35f44 Compare January 14, 2023 16:23
@Dylan-DPC
Copy link
Member

thanks
@bors r+

@bors
Copy link
Contributor

bors commented Jan 14, 2023

📌 Commit 0b35f44 has been approved by Dylan-DPC

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2023
@anden3
Copy link
Contributor Author

anden3 commented Jan 14, 2023

I found some more, pushing another commit soon.

@Dylan-DPC
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 14, 2023

📌 Commit 2fea03f has been approved by Dylan-DPC

It is now in the queue for this repository.

@matthiaskrgr matthiaskrgr mentioned this pull request Jan 14, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2023
@bors
Auto merge of rust-lang#106866 - matthiaskrgr:rollup-r063s44, r=matth…
afaf3e0 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#105526 (libcore: make result of iter::from_generator Clone)
 - rust-lang#106563 (Fix `unused_braces` on generic const expr macro call)
 - rust-lang#106661 (Stop probing for statx unless necessary)
 - rust-lang#106820 (Deprioritize fulfillment errors that come from expansions.)
 - rust-lang#106828 (rustdoc: remove `docblock` class from notable trait popover)
 - rust-lang#106849 (Allocate one less vec while parsing arrays)
 - rust-lang#106855 (rustdoc: few small cleanups)
 - rust-lang#106860 (Remove various double spaces in the libraries.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e0eb63a into rust-lang:master Jan 15, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 15, 2023
@anden3 anden3 deleted the doc-double-spaces branch January 15, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Dylan-DPC Dylan-DPC

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
6 participants
@anden3 @rustbot @matthiaskrgr @Dylan-DPC @bors @m-ou-se