-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize const slice::split_at #108273
Stabilize const slice::split_at #108273
Conversation
r? @m-ou-se (rustbot has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
This stabilizes the use of the following method in const context: impl<T> [T] { pub const fn split_at(&self, mid: usize) -> (&[T], &[T]); }
70a5ade
to
b46b05d
Compare
As an example use case, this stabilization would allow me to remove a function that has to use unsafe code to achieve the same thing, which is required for the parsing of literals in const context in the |
@rustbot label +T-libs-api -T-libs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completed FCP in #101158.
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (0bcfd2d): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 643.398s -> 640.795s (-0.40%) |
This stabilizes the use of the following method in const context:
cc tracking issue #101158