update Miri #108500
Merged
update Miri #108500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add scfix test I'm not sure if we currently *guarantee* to pass this test, but at least I was unable to get it to fail. Cc `@cbeuw`
It was broken, and the fixed version actually fails...
remove scfix test It was broken, and the fixed version actually fails... Thanks `@cbeuw` !
Co-authored-by: Ralf Jung <[email protected]>
Explain how to make josh authenticate with github via ssh Without this I was unable to push, even though pushing directly to https without josh works.
This shim is required for `core::hint::spin_loop` on `arm` targets
This makes sure that the interface of `miri_host_to_target_path` is compatible with `CStr` for targets where `c_char` is unsigned (such as ARM). This commit changes the signature of `miri_host_to_target_path` in the README and in all test cases.
Specifically `aarch64-unknown-linux-gnu` and `arm-unknown-linux-gnueabi`
Co-authored-by: Ralf Jung <[email protected]>
cargo-miri: bump `rustc_tools_util` crate This dedupes crate versions in rust repo.
Get Miri working on ARM - Add a shim for `llvm.arm.hint`, which is required by `core::hint::spin_loop` on `arm` targets. The shim simply calls `yield_active_thread` on a YIELD hint, just like the shim for `llvm.aarch64.isb` that's already present. - Change the signature of `miri_host_to_target_path` to use `c_char` instead of `i8`, to make it compatible with `CStr` on targets where `c_char` is unsigned. The implementation of `miri_host_to_target_path` accesses the memory as bytes and does not need to be adjusted. - Enable ARM targets in CI. Specifically, `aarch64-unknown-linux-gnu` and `arm-unknown-linux-gnueabi` on the Linux host. Since all tests also pass for `aarch64-unknown-linux-gnu` I took the liberty of adding that target to CI as well. Fixes rust-lang#2791
rustbot
added
the
S-waiting-on-review
|
The Miri subtree was changed cc @rust-lang/miri |
|
These commits modify the If this was intentional then you can ignore this comment. |
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 26, 2023
update Miri r? `@ghost`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 27, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#108319 (Don't project specializable RPITIT projection) - rust-lang#108364 (Unify validity checks into a single query) - rust-lang#108463 (bootstrap: Update the output of the `check` descriptions) - rust-lang#108477 (Make `match` arm comma suggestion more clear) - rust-lang#108486 (Merge diagnostic_items duplicate diagnostics) - rust-lang#108494 (Clean up JS files code a bit) - rust-lang#108500 (update Miri) - rust-lang#108502 (Don't trigger error for ReError when other region is empty.) - rust-lang#108513 (Remove `@nagisa` from review rotation) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ghost