Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #126910

Closed
wants to merge 21 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
9f0c7f0
transmute size check: properly account for alignment
RalfJung May 29, 2024
d630f5d
Show notice about "never used" for enum
long-long-float Apr 28, 2024
a264bff
Mark assoc tys live only if the trait is live
mu001999 Jun 18, 2024
3f2f843
Ensure we don't accidentally succeed when we want to report an error
oli-obk Jun 13, 2024
3390159
Add `rust_analyzer` as a predefined tool
Veykril May 18, 2024
57a82e0
On short error format, append primary span label to message
estebank Jun 21, 2024
594fa01
not use offset when there is not ends with brace
bvanjoi Jun 23, 2024
8cfd4b1
Unify the precedence level for PREC_POSTFIX and PREC_PAREN
dtolnay Jun 24, 2024
273447c
Rename the 2 unambiguous precedence levels to PREC_UNAMBIGUOUS
dtolnay Jun 24, 2024
ba5ec1f
Suggest inline const blocks for array initialization
GrigorenkoPV Jun 24, 2024
8ffb5f9
compiletest: make the crash test error message abit more informative
matthiaskrgr Jun 13, 2024
1368c5e
Rollup merge of #124460 - long-long-float:show-notice-about-enum-with…
matthiaskrgr Jun 24, 2024
a7e148d
Rollup merge of #125241 - Veykril:tool-rust-analyzer, r=davidtwco
matthiaskrgr Jun 24, 2024
621ab36
Rollup merge of #125740 - RalfJung:transmute-size-check, r=oli-obk
matthiaskrgr Jun 24, 2024
b77d610
Rollup merge of #126413 - matthiaskrgr:crshmsg, r=oli-obk
matthiaskrgr Jun 24, 2024
4b78058
Rollup merge of #126618 - mu001999-contrib:dead/enhance, r=pnkfelix
matthiaskrgr Jun 24, 2024
a12f2d2
Rollup merge of #126673 - oli-obk:dont_rely_on_err_reporting, r=compi…
matthiaskrgr Jun 24, 2024
52a90f4
Rollup merge of #126804 - estebank:short-error-primary-label, r=david…
matthiaskrgr Jun 24, 2024
1ae001d
Rollup merge of #126868 - bvanjoi:fix-126764, r=davidtwco
matthiaskrgr Jun 24, 2024
98379cf
Rollup merge of #126893 - dtolnay:prec, r=compiler-errors
matthiaskrgr Jun 24, 2024
4aaa3b0
Rollup merge of #126899 - GrigorenkoPV:suggest-const-block, r=davidtwco
matthiaskrgr Jun 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
compiletest: make the crash test error message abit more informative
matthiaskrgr committed Jun 24, 2024
commit 8ffb5f936a17190ad9aae442fe52c709521c5b29
9 changes: 5 additions & 4 deletions src/tools/compiletest/src/runtest.rs
Original file line number Diff line number Diff line change
@@ -374,11 +374,12 @@ impl<'test> TestCx<'test> {

// if a test does not crash, consider it an error
if proc_res.status.success() || matches!(proc_res.status.code(), Some(1 | 0)) {
self.fatal(
"test no longer crashes/triggers ICE! Please give it a mearningful name, \
self.fatal(&format!(
"crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, \
add a doc-comment to the start of the test explaining why it exists and \
move it to tests/ui or wherever you see fit.",
);
move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description \
ensures that the corresponding ticket is auto-closed upon merge."
));
}
}

3 changes: 3 additions & 0 deletions triagebot.toml
Original file line number Diff line number Diff line change
@@ -811,6 +811,9 @@ If appropriate, please update `CONFIG_CHANGE_HISTORY` in `src/bootstrap/src/util
[mentions."src/bootstrap/src/core/build_steps/llvm.rs"]
message = "This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp."

[mentions."test/crashes"]
message = "This PR changes a file inside `tests/crashes`. If a crash was fixed, please move into the correspondig `ui` subdir and add 'Fixes #<issueNr>' to the pr description to autoclose the issue upon merge."

[mentions."tests/ui/deriving/deriving-all-codegen.stdout"]
message = "Changes to the code generated for builtin derived traits."
cc = ["@nnethercote"]