Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #130964

Merged
merged 26 commits into from
Sep 28, 2024
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
ba3b536
Fix `io::Take::read_buf`
a1phyr May 22, 2024
04710e2
Fix `io::BufReader` uses of `read_buf`
a1phyr May 22, 2024
bf76888
Fix `io::default_read_to_end` uses of `read_buf`
a1phyr May 22, 2024
4b8a66c
Add tests
a1phyr Sep 23, 2024
d77664b
Add a comment to `Read::read_buf`
a1phyr Sep 23, 2024
d4ee408
Check allow instantiating object trait binder when upcasting and in n…
compiler-errors Sep 25, 2024
fa3215d
Reference UNSPECIFIED instead of INADDR_ANY in join_multicast_v4
tyilo Sep 27, 2024
0bf9289
Make clashing_extern_declarations considering generic args for ADT field
surechen Sep 27, 2024
3b9db47
rustdoc: update `ProcMacro` docs section on helper attributes
obi1kenobi Sep 27, 2024
282d044
Revert "ci: Try to remove unused Xcode dirs"
workingjubilee Sep 27, 2024
a2a4ea0
Partially revert "ci: Use mv instead of cp in upload step"
workingjubilee Sep 27, 2024
8302f2e
add even more tests for ptr-to-ptr casts on trait objects
Sep 27, 2024
53f45c4
borrowck: use subtyping instead of equality for ptr-to-ptr casts
Sep 27, 2024
4fb097a
Instantiate binders when checking supertrait upcasting
compiler-errors Sep 27, 2024
d753aba
Get rid of a_is_expected from ToTrace
compiler-errors Sep 27, 2024
bcf8cf2
tests: issue-69488.rs => load-preserves-partial-init-issue-69488.rs
workingjubilee Sep 26, 2024
a1fbf25
tests: issue-14309.* => repr-rust-is-undefined.*
workingjubilee Sep 27, 2024
19d5568
tests: issue-34798.rs => allow-phantomdata-in-ffi.rs
workingjubilee Sep 27, 2024
6e9db86
Rollup merge of #125404 - a1phyr:fix-read_buf-uses, r=workingjubilee
matthiaskrgr Sep 28, 2024
4e510da
Rollup merge of #130866 - compiler-errors:dyn-instantiate-binder, r=lcnr
matthiaskrgr Sep 28, 2024
9c4b81c
Rollup merge of #130922 - tyilo:udp-unspecified, r=ibraheemdev
matthiaskrgr Sep 28, 2024
2df6b07
Rollup merge of #130924 - surechen:fix_130851, r=compiler-errors
matthiaskrgr Sep 28, 2024
7e32221
Rollup merge of #130939 - obi1kenobi:patch-2, r=aDotInTheVoid
matthiaskrgr Sep 28, 2024
6b5cd4e
Rollup merge of #130940 - workingjubilee:remove-space-saving-operatio…
matthiaskrgr Sep 28, 2024
58d0730
Rollup merge of #130944 - lukas-code:ptr-ptr-sub, r=compiler-errors
matthiaskrgr Sep 28, 2024
5d7db93
Rollup merge of #130953 - workingjubilee:rename-a-few-ctypes-tests, r…
matthiaskrgr Sep 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a comment to Read::read_buf
a1phyr committed Sep 23, 2024
commit d77664bed945fbbd5ab102f59a38b1ef0e728b10
2 changes: 2 additions & 0 deletions library/std/src/io/mod.rs
Original file line number Diff line number Diff line change
@@ -978,6 +978,8 @@ pub trait Read {
/// with uninitialized buffers. The new data will be appended to any existing contents of `buf`.
///
/// The default implementation delegates to `read`.
///
/// This method makes it possible to return both data and an error but it is advised against.
#[unstable(feature = "read_buf", issue = "78485")]
fn read_buf(&mut self, buf: BorrowedCursor<'_>) -> Result<()> {
default_read_buf(|b| self.read(b), buf)