Allow const patterns of matches to contain pattern types #138393
+246
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to pattern match on a type containing a pattern type will currently fail with an ICE
because the compiler tries to generate a MIR
BinOp(Eq)
operation on a pattern type, which is not supported. While we could support that, there are side effects of allowing this (none that would compile, but the compiler would simultaneously think it could==
pattern types and that it could not becausePartialEq
is not implemented. So instead I change the logic for pattern matching to transmute pattern types to their base type before comparing.r? @BoxyUwU
cc #123646 @scottmcm @joshtriplett