Skip to content

Add Arc::is_unique #138939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Add Arc::is_unique #138939

merged 1 commit into from
Apr 28, 2025
+61 −8

Conversation

SabrinaJewson
Copy link
Contributor

Adds

impl<T> Arc<T> {
    pub fn is_unique(this: &Self) -> bool;
}

Tracking issue: #138938
ACP: rust-lang/libs-team#560

@rustbot
Copy link
Collaborator

rustbot commented Mar 25, 2025

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 25, 2025
@SabrinaJewson SabrinaJewson mentioned this pull request Mar 25, 2025
Open
4 tasks
tgross35
tgross35 requested changes Apr 27, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two doc nits, otherwise this looks good to me.

tgross35
tgross35 approved these changes Apr 27, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just needs a squash

@tgross35 tgross35 assigned tgross35 and unassigned workingjubilee Apr 27, 2025
@tgross35
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 27, 2025

📌 Commit 2ab4034 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2025
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 28, 2025
@ChrisDenton
Rollup merge of rust-lang#138939 - SabrinaJewson:arc-is-unique, r=tgr…
84e92b1 
…oss35

Add `Arc::is_unique`

Adds

```rs
impl<T> Arc<T> {
    pub fn is_unique(this: &Self) -> bool;
}
```

Tracking issue: rust-lang#138938
ACP: rust-lang/libs-team#560
@ChrisDenton ChrisDenton mentioned this pull request Apr 28, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2025
@bors
Auto merge of rust-lang#140376 - ChrisDenton:rollup-use71pz, r=ChrisD…
4f1494c 
…enton

Rollup of 10 pull requests

Successful merges:

 - rust-lang#136160 (Remove backticks from `ShouldPanic::YesWithMessage`'s `TrFailedMsg`)
 - rust-lang#138395 (Download GCC from CI on test builders)
 - rust-lang#138737 (uefi: Update r-efi)
 - rust-lang#138939 (Add `Arc::is_unique`)
 - rust-lang#139224 (fix(test): Expose '--no-capture' in favor of `--nocapture`)
 - rust-lang#139546 (std(docs): clarify how std::fs::set_permisions works with symlinks)
 - rust-lang#139883 (crashes: more tests)
 - rust-lang#140345 (Avoid re-interning in `LateContext::get_def_path`)
 - rust-lang#140351 (docs: fix incorrect stability markers on `std::{todo, matches}`)
 - rust-lang#140359 (specify explicit safety guidance for from_utf8_unchecked)

r? `@ghost`
`@rustbot` modify labels: rollup
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 28, 2025
@ChrisDenton
Rollup merge of rust-lang#138939 - SabrinaJewson:arc-is-unique, r=tgr…
d603142 
…oss35

Add `Arc::is_unique`

Adds

```rs
impl<T> Arc<T> {
    pub fn is_unique(this: &Self) -> bool;
}
```

Tracking issue: rust-lang#138938
ACP: rust-lang/libs-team#560
@ChrisDenton ChrisDenton mentioned this pull request Apr 28, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2025
@bors
Auto merge of rust-lang#140377 - ChrisDenton:rollup-sec6d4x, r=ChrisD…
03ffc9f 
…enton

Rollup of 9 pull requests

Successful merges:

 - rust-lang#138395 (Download GCC from CI on test builders)
 - rust-lang#138737 (uefi: Update r-efi)
 - rust-lang#138939 (Add `Arc::is_unique`)
 - rust-lang#139224 (fix(test): Expose '--no-capture' in favor of `--nocapture`)
 - rust-lang#139546 (std(docs): clarify how std::fs::set_permisions works with symlinks)
 - rust-lang#139883 (crashes: more tests)
 - rust-lang#140345 (Avoid re-interning in `LateContext::get_def_path`)
 - rust-lang#140351 (docs: fix incorrect stability markers on `std::{todo, matches}`)
 - rust-lang#140359 (specify explicit safety guidance for from_utf8_unchecked)

r? `@ghost`
`@rustbot` modify labels: rollup
@ChrisDenton ChrisDenton mentioned this pull request Apr 28, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2025
@bors
Auto merge of rust-lang#140378 - ChrisDenton:rollup-3mj0wp9, r=ChrisD…
21079f5 
…enton

Rollup of 8 pull requests

Successful merges:

 - rust-lang#138395 (Download GCC from CI on test builders)
 - rust-lang#138737 (uefi: Update r-efi)
 - rust-lang#138939 (Add `Arc::is_unique`)
 - rust-lang#139224 (fix(test): Expose '--no-capture' in favor of `--nocapture`)
 - rust-lang#139546 (std(docs): clarify how std::fs::set_permisions works with symlinks)
 - rust-lang#140345 (Avoid re-interning in `LateContext::get_def_path`)
 - rust-lang#140351 (docs: fix incorrect stability markers on `std::{todo, matches}`)
 - rust-lang#140359 (specify explicit safety guidance for from_utf8_unchecked)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 55f9326 into rust-lang:master Apr 28, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 28, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2025
@rust-timer
Unrolled build for rust-lang#138939
abb427d 
Rollup merge of rust-lang#138939 - SabrinaJewson:arc-is-unique, r=tgross35

Add `Arc::is_unique`

Adds

```rs
impl<T> Arc<T> {
    pub fn is_unique(this: &Self) -> bool;
}
```

Tracking issue: rust-lang#138938
ACP: rust-lang/libs-team#560
@SabrinaJewson SabrinaJewson deleted the arc-is-unique branch April 28, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
5 participants
@SabrinaJewson @rustbot @tgross35 @bors @workingjubilee