Skip to content

Fix accidental type inference in array coercion #140283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+28 −1
Open

Fix accidental type inference in array coercion #140283

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9f3f13
fix accidental type inference in array coercion
adwinwhite Apr 25, 2025
b31fa29
add ui test
adwinwhite Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion compiler/rustc_hir_typeck/src/expr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1760,7 +1760,9 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
let coerce_to = expected
.to_option(self)
.and_then(|uty| match *self.try_structurally_resolve_type(expr.span, uty).kind() {
ty::Array(ty, _) | ty::Slice(ty) => Some(ty),
// Avoid using a type variable as the coerce_to type, as it may resolve
// during the first coercion instead of being based on the common type.
ty::Array(ty, _) | ty::Slice(ty) if !ty.is_ty_var() => Some(ty),
_ => None,
})
.unwrap_or_else(|| self.next_ty_var(expr.span));
Expand Down