Check if format argument is identifier to avoid error err-emit #140286
+140
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Signed-off-by: xizheyin <[email protected]>
Signed-off-by: xizheyin <[email protected]>
xizheyin
commented
Apr 25, 2025
| if !self.consume('}') { | ||
| return; | ||
| // If the argument is an identifier, it may be a field access. | ||
| if arg.is_identifier() { |
There was a problem hiding this comment.
Here I first determine if it's an identifier before considering if it's a field access, e.g. foo.0, foo.a
| } | ||
| } else if matches!(arg.position, ArgumentNamed(_) | ArgumentIs(_)) { |
There was a problem hiding this comment.
I only trigger this error when there is an explicit explicit location or a named argument.
This is because the case of ArgumentImplicitlyIs is more complex, e.g. “{ x”, and I think it should be prioritized to output the missing } over this error. For arguments that have a name or an explicit position, it's more appropriate to output invalid format specifier instead of missing }.
Also, the original logic does not emit an ERROR in ArgumentImplicitlyIs case, so I'm not making radical changes for now. It can be left for later enhancements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139104
When
argumentis not an identifier, it should not be considered a field access. I checked this and if not emit an invalid format string error. I think we could do with a little finer error handling, I'll open an issue to track this down later.The first commit submits the ui test, the second commits the code and the changes to the test output.
r? compiler