Feature-gate explicit unboxed closure method calls & manual impls, #19587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huonw
force-pushed
the
closure-feature-gate
branch
from
7e98cb6 to
0367740
Compare
|
r+ if you comment the new codes with a short description of what they represent |
detect UFCS drop and allow UFCS methods to have explicit type parameters. Work towards rust-lang#18875. Since code could previously call the methods & implement the traits manually, this is a [breaking-change] Closes rust-lang#19586. Closes rust-lang#19375.
huonw
force-pushed
the
closure-feature-gate
branch
from
0367740 to
e852419
Compare
| E0172 | ||
| E0172, | ||
| E0173, // manual implementations of unboxed closure traits are experimental | ||
| E0174 // explicit use of unboxed closure methods are experimental |
There was a problem hiding this comment.
Curious, any particular reason why we want these codes commented here? This file isn't really meant for any sort of read consumption, it's more of a manifest.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 9, 2014
detect UFCS drop and allow UFCS methods to have explicit type parameters. Work towards rust-lang#18875. Since code could previously call the methods & implement the traits manually, this is a [breaking-change] Closes rust-lang#19586. Closes rust-lang#19375.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detect UFCS drop and allow UFCS methods to have explicit type parameters.
Work towards #18875.
Since code could previously call the methods & implement the traits
manually, this is a
[breaking-change]
Closes #19586. Closes #19375.