Rollup of 7 pull requests #22170
Closed
Rollup of 7 pull requests #22170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richo
commented
Feb 11, 2015
richo
commented
- Successful merges: lint: Deny #[no_mangle] const items #21881, Make the live code analysis visit method declarations. #22048, fix and macro-ify map benches, fixes #22134 #22151, Remove FIXME in librbml #22161, Documentation fix for PathBuf#pop #22162, Tweak wording of copy_nonoverlapping_memory to remove misleading 'allocated'. #22164, Forbid undefined names in macro use / macro reexport #22167
- Failed merges:
This renames the PrivateNoMangleFns lint to allow both to happen in a single pass, since they do roughly the same work.
The live code analysis only visited the function's body when visiting a method, and not the FnDecl and the generics, resulting in code to be incorrectly marked as unused when it only appeared in the generics, the arguments, or the return type, whereas the same code in non-method functions was correctly detected as used. Fixes rust-lang#20343.
Given that this is entirely internal, this enhancement isn't going to be needed. And if it is, we'll add it. Closes rust-lang#2741.
It returns `false`, not `none`.
…ocated'. It doesn't have to be a literal memory allocation (ala malloc), e.g. it can be in static memory, so saying "allocated" is mildly misleading.
…lister This renames the PrivateNoMangleFns lint to allow both to happen in a single pass, since they do roughly the same work. Closes rust-lang#21856 Open questions: [ ]: Do the tests actually pass (I'm running make check and running out the door now) [ ]: Is the name of this lint ok. it seems to mostly be fine with [convention](https://github.com/rust-lang/rfcs/blob/cc53afbe5dea41e1f7d1c3dce71e013abe025211/text/0344-conventions-galore.md#lints) [ ]: I'm not super thrilled about the warning text r? @kmcallister (Shamelessly nominating because you were looking at my other ticket)
…kfelix The live code analysis only visited the function's body when visiting a method, and not the FnDecl and the generics, resulting in code to be incorrectly marked as unused when it only appeared in the generics, the arguments, or the return type, whereas the same code in non-method functions was correctly detected as used. Fixes rust-lang#20343. Originally I just added a call to `walk_generics` and `walk_fndecl` alongside `walk_block` but then I noticed the `walk_method_helper` function did pretty much the same thing. The only difference is that it also calls `visit_mac`, but since this is not going to happen at this stage, I think it's ok. However let me know if this was not the right thing to do.
…hton Given that this is entirely internal, this enhancement isn't going to be needed. And if it is, we'll add it. Closes rust-lang#2741.
It returns `false`, not `None`.
It doesn't have to be a literal memory allocation (ala malloc), e.g. it can be in static memory, so saying "allocated" is mildly misleading. Thanks to @mahkoh for pointing it out. r? @steveklabnik
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks! Today though I'd like to prioritize landing of #21972 and we may have some more PRs to rollup after that, so we may want to create one after that if necessary :) |
|
@alexcrichton thanks for the implicit assist with #21972. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.