Partially format librustc_mir with rustfmt. #28884
Merged
+651
−529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains some of the changes proposed by a rustfmt invocation, chosen based on the fairly non-deterministic metric of how much I liked the change. I expect we will run rustfmt on this crate again later, probably accepting more of its changes. For now, this is already an improvement over the status-quo.
|
CC @nrc |
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -113,45 +113,128 @@ pub struct Expr<'tcx> { | |||
|
|
|||
| #[derive(Clone, Debug)] | |||
| pub enum ExprKind<'tcx> { | |||
There was a problem hiding this comment.
This enum has inflated from 40 lines to 120. Did its author perhaps intend it to fit on a single screen?
There was a problem hiding this comment.
|
r+ from me, @nikomatsakis not sure if you want to glance over and see if anything offends you |
|
@bors r+ I don't hate it too much, which is probably the best you can expect. :) |
|
📌 Commit c73e78c has been approved by |
bors
added a commit
that referenced
this pull request
Oct 7, 2015
This commit contains some of the changes proposed by a rustfmt invocation, chosen based on the fairly non-deterministic metric of how much I liked the change. I expect we will run rustfmt on this crate again later, probably accepting more of its changes. For now, this is already an improvement over the status-quo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains some of the changes proposed by a rustfmt invocation,
chosen based on the fairly non-deterministic metric of how much I liked the
change. I expect we will run rustfmt on this crate again later, probably
accepting more of its changes. For now, this is already an improvement over
the status-quo.