[breaking-change] Remove TypedArena::with_capacity #36657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function is unused by rustc. Also, it doesn't really follow the usual meaning of a `with_capacity` function because the first chunk allocation is now delayed until the first `alloc` call. This change reduces the size of `TypedArena` by one `usize`.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ Thanks! |
|
📌 Commit cf50f5f has been approved by |
|
⌛ Testing commit cf50f5f with merge d6954e8... |
|
💔 Test failed - auto-win-gnu-64-opt |
|
@eddyb: run-make\output-type-permutations failed. I don't understand what went wrong. Is it the compile warnings about |
|
Don't see how it's relevant. @bors retry |
|
⌛ Testing commit cf50f5f with merge 7ce16f6... |
|
💔 Test failed - auto-mac-64-opt-rustbuild |
|
@eddyb: another failure that's not my fault? It's an exception in Python code... |
|
The bots may be acting up, but it's a weekend so I don't think I have any way of confirming. @bors retry |
bors
added a commit
that referenced
this pull request
Sep 24, 2016
[breaking-change] Remove TypedArena::with_capacity This is a follow-up to #36592. The function is unused by rustc. Also, it doesn't really follow the usual meaning of a `with_capacity` function because the first chunk allocation is now delayed until the first `alloc` call. This change reduces the size of `TypedArena` by one `usize`. @eddyb: we discussed this on IRC. Would you like to review it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #36592.
The function is unused by rustc. Also, it doesn't really follow the
usual meaning of a
with_capacityfunction because the first chunkallocation is now delayed until the first
alloccall.This change reduces the size of
TypedArenaby oneusize.@eddyb: we discussed this on IRC. Would you like to review it?