[LLVM 4.0] OptimizationDiagnostic FFI forward compatibility #37982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- getMsg() changed to return std::string by-value. Fix: copy the data to a rust String during unpacking. - getPassName() changed to return StringRef
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
hanna-kruppe
changed the title
|
There don't seem to be any tests for |
|
@bors: r+ Thanks! This seems like the API we'd chuck at any time if it's never used... |
|
📌 Commit 7304001 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 25, 2016
[LLVM 4.0] OptimizationDiagnostic FFI forward compatibility - getMsg() changed to return std::string by-value. Fix: copy the data to a rust String during unpacking. - getPassName() changed to return StringRef cc #37609
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #37609