Skip to content

Update the libcompiler_builtins submodule #44921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2017
Merged

Update the libcompiler_builtins submodule #44921

merged 1 commit into from
Oct 1, 2017

Conversation

est31
Copy link
Member

@est31 est31 commented Sep 29, 2017

Pulls in the latest changes from libcompiler_builtins.

It should work, but it would be best if this wouldn't get put into a rollup so that bisecting is possible if there is a regression.

r? @alexcrichton

@est31 est31 changed the title Update the libcompiler_builtins submodule [WIP] Update the libcompiler_builtins submodule Sep 29, 2017
@est31 est31 changed the title [WIP] Update the libcompiler_builtins submodule Update the libcompiler_builtins submodule Sep 29, 2017
alexcrichton
alexcrichton reviewed Sep 29, 2017
View reviewed changes
src/rustc/compiler_builtins_shim/Cargo.toml Outdated
@@ -16,6 +16,7 @@ core = { path = "../../libcore" }

[build-dependencies]
gcc = "0.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the gcc dep can be removed, right?

@alexcrichton
Copy link
Member

Just one small nit but otherwise r=me

@shepmaster shepmaster added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 29, 2017
@est31 est31 force-pushed the master branch 2 times, most recently from 0eb7d4c to 4114d68 Compare September 29, 2017 23:44
@Mark-Simulacrum
Copy link
Member

@bors r=alexcrichton

@bors
Copy link
Collaborator

bors commented Sep 30, 2017

📌 Commit 4114d68 has been approved by alexcrichton

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 30, 2017
@bors
Copy link
Collaborator

bors commented Sep 30, 2017

⌛ Testing commit 4114d68 with merge d1e4075d21c2b9fa4938e177fa2fc64894fdf197...

@bors
Copy link
Collaborator

bors commented Sep 30, 2017

💔 Test failed - status-appveyor

@est31
Copy link
Member Author

est31 commented Sep 30, 2017

I'm not sure this is caused by this PR.

[01:20:13] thread '[run-make] run-make\issue-26092' panicked at 'explicit panic', src\tools\compiletest\src\runtest.rs:2433:8
[01:20:13] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:20:13] 
[01:20:13] 
[01:20:13] failures:
[01:20:13]     [run-make] run-make\issue-26092
[01:20:13] 
[01:20:13] test result: FAILED. 160 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[01:20:13] 
[01:20:13] thread 'main' panicked at 'Some tests failed', src\tools\compiletest\src\main.rs:323:21

@bors retry

@bors
Copy link
Collaborator

bors commented Oct 1, 2017

⌛ Testing commit 4114d68 with merge 1c09315...

bors added a commit that referenced this pull request Oct 1, 2017
@bors
Auto merge of #44921 - est31:master, r=alexcrichton
1c09315 
Update the libcompiler_builtins submodule

Pulls in the latest changes from libcompiler_builtins.

It should work, but it would be best if this wouldn't get put into a rollup so that bisecting is possible if there is a regression.

r? @alexcrichton
@bors
Copy link
Collaborator

bors commented Oct 1, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 1c09315 to master...

@bors bors merged commit 4114d68 into rust-lang:master Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton left review comments

Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@est31 @alexcrichton @Mark-Simulacrum @bors @shepmaster