Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Cargo metadata to libstd #45669

Merged
merged 3 commits into from
Nov 4, 2017
Merged

add Cargo metadata to libstd #45669

merged 3 commits into from
Nov 4, 2017

Conversation

cardoe
Copy link
Contributor

@cardoe cardoe commented Oct 31, 2017

Add license and repository metadata to libstd

cardoe added 2 commits October 31, 2017 14:49
@cardoe
add license data to libstd
ea103ef 
Include the license of libstd in the cargo metadata
@cardoe
add repository info to libstd
4519192 
Include the repository info for libstd in the Cargo metadata.
@cardoe
Copy link
Contributor Author

cardoe commented Oct 31, 2017

I'm working on some additions for https://github.com/cargo/cargo-bitbake to generate the necessary license data for compliance validation for Yocto based distros. I made the assumption that all dependencies in crates.io must comply with the packaging requirements which works until I attempted to include libstd's data (which I know is not on crates.io). I am hoping we can include this so I don't have to special case libstd. As well as some day libstd being available in crates.io

@cardoe
add description to libstd
86c09f3 
Include a description field for libstd in Cargo metadata.
@cardoe
Copy link
Contributor Author

cardoe commented Oct 31, 2017

Feel free to squash or change or ignore any of these commits.

@cardoe cardoe mentioned this pull request Oct 31, 2017
Open
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 1, 2017
@kennytm
Copy link
Member

kennytm commented Nov 3, 2017

@bors r+ rollup

@cardoe Thanks!

Do you need to update other crates like libtest as well, or augmenting libstd is enough?

@bors
Copy link
Collaborator

bors commented Nov 3, 2017

📌 Commit 86c09f3 has been approved by kennytm

@cardoe
Copy link
Contributor Author

cardoe commented Nov 4, 2017

I'd like to do all of them @kennytm but I figured I'd start here to see if the maintainers were receptive.

kennytm added a commit to kennytm/rust that referenced this pull request Nov 4, 2017
@kennytm
Rollup merge of rust-lang#45669 - cardoe:metadata, r=kennytm
1815265 
add Cargo metadata to libstd

Add license and repository metadata to libstd
@kennytm kennytm mentioned this pull request Nov 4, 2017
Merged
@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2017
bors added a commit that referenced this pull request Nov 4, 2017
@bors
Auto merge of #45755 - kennytm:rollup, r=kennytm
9acc333 
Rollup of 9 pull requests

- Successful merges: #45548, #45610, #45639, #45669, #45681, #45718, #45722, #45739, #45746
- Failed merges:
@bors bors merged commit 86c09f3 into rust-lang:master Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cardoe @kennytm @bors