Rename C-like enum to Field-less enum #46187
Conversation
There is no need to reference the C programming language to explain this concept.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
added
S-waiting-on-review
|
Context: https://internals.rust-lang.org/t/proposal-bikeshed-rename-c-like-enumeration/6209 Randomly reassigning to someone in the docs team… r? @frewsxcv |
|
Until the decisions is made, we can't accept this PR. |
|
Pending discussion on #46348 from lang team, i'm reopening this PR. |
kennytm
added
S-waiting-on-team
|
Randomly reassigning to member on the lang team… GitHub doesn't accept it, reassigning… r? @nikomatsakis |
There was a problem hiding this comment.
The lang team (via @withoutboats) has given a quiet assent for this change, so i'll take it over from a docs perspective.
src/librustc/diagnostics.rs
Outdated
| @@ -1641,13 +1641,13 @@ impl Foo { | |||
| These attributes do not work on typedefs, since typedefs are just aliases. | |||
|
|
|||
| Representations like `#[repr(u8)]`, `#[repr(i64)]` are for selecting the | |||
| discriminant size for C-like enums (when there is no associated data, e.g. | |||
| discriminant size for enums with no data fields on any of the variants, e.g. | |||
| `enum Color {Red, Blue, Green}`), effectively setting the size of the enum to | |||
There was a problem hiding this comment.
You took out the opening parenthesis, but left the closing one here (after "enum Color").
src/librustc/diagnostics.rs
Outdated
| `enum Color {Red, Blue, Green}`), effectively setting the size of the enum to | ||
| the size of the provided type. Such an enum can be cast to a value of the same | ||
| type as well. In short, `#[repr(u8)]` makes the enum behave like an integer | ||
| with a constrained set of allowed values. | ||
|
|
||
| Only C-like enums can be cast to numerical primitives, so this attribute will | ||
| Only field-less enums can be cast to numerical primitives, so this attribute will |
There was a problem hiding this comment.
This line is longer than 80 characters, which caused the build to fail on travis.
|
Fixed both. |
kennytm
added
A-docs
kennytm
removed
the
S-waiting-on-team
|
Excellent! Thanks so much! @bors r+ rollup |
|
📌 Commit a126a73 has been approved by |
Rename C-like enum to Field-less enum There is no need to reference the C programming language to explain this concept.
kennytm
added
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
There is no need to reference the C programming language to explain this concept.