Use partial but correct vtable layout #53757
Merged
+32
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
You only added that more detailed layout specifically for validation, right? So this should not regress anything else? Please add a comment in |
|
There's a Yea, only validation and debug symbols were affected |
|
That FIXME doesn't tell me much -- in particular, it doesn't explain that even the size of the vtable, naively computed, is wrong (the thing that lead to this having to be backported, right?) |
RalfJung
reviewed
Aug 28, 2018
| be not object safe and thus excluded from the vtable. | ||
| Increase this counter if you tried to implement this but | ||
| failed to do it without duplicating a lot of code from | ||
| other places in the compiler: 2 |
|
@bors r+ |
|
📌 Commit f318ba2 has been approved by |
bors
added
S-waiting-on-bors
eddyb
approved these changes
Aug 29, 2018
bors
added a commit
that referenced
this pull request
Aug 30, 2018
Use partial but correct vtable layout r? @RalfJung who suggested to also do this change for nightly, not just beta
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @RalfJung who suggested to also do this change for nightly, not just beta