Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 12 pull requests #59289

Closed
wants to merge 48 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
6fb5b73
dbg!() without parameters.
Jan 22, 2019
ea9e2c4
Test behaviour
Jan 31, 2019
c5fe405
Clarify distinction between floor() and trunc()
jonhoo Feb 28, 2019
b91ab62
Fix a tiny error in documentation of std::pin.
taeguk Mar 5, 2019
96e361f
Fix buffer invalidation for BufRead
andre-vm Mar 4, 2019
c36d91c
Fix buffer invalidation at BufReader.read_vectored
Mar 6, 2019
b9d12ed
Be more discerning on when to attempt suggesting a comma in a macro i…
estebank Mar 11, 2019
27abd52
Fix operator precedence
estebank Mar 13, 2019
4e5692d
test that wildcard type `_` is not duplicated by `type Foo<X> = (X, X…
pnkfelix Jan 18, 2019
541ad45
Add default keyword handling in rustdoc
GuillaumeGomez Mar 5, 2019
a7bd36c
Add peer_addr function to UdpSocket
LinusU Mar 11, 2019
bf473e3
Mark UdpSocket peer_addr unstable w/ tracking issue
LinusU Mar 12, 2019
24e3fa0
Document UdpSocket peer_addr NotConnected error
LinusU Mar 12, 2019
7f7cfae
Add test for UdpSocket peer_addr
LinusU Mar 12, 2019
7e73cd4
Fix test names regarding ip version
LinusU Mar 12, 2019
214110b
Add UdpSocket peer_addr implementation for L4Re
LinusU Mar 16, 2019
81d5fb5
Add UdpSocket peer_addr implementation for Wasm
LinusU Mar 16, 2019
6ea1888
Add lint for redundant imports
fabric-and-ink Feb 22, 2019
6671096
Remove redundant imports
fabric-and-ink Mar 10, 2019
1129a34
Edit comments
fabric-and-ink Mar 16, 2019
fef7e9d
Improve warning
fabric-and-ink Mar 16, 2019
567649b
Bless tests
fabric-and-ink Mar 16, 2019
ceca4a1
Distinguish between imported and defined items
fabric-and-ink Mar 16, 2019
29a7732
Remove redundant import
fabric-and-ink Mar 16, 2019
1062628
Edit ui tests
fabric-and-ink Mar 16, 2019
bbbc446
Replace REDUNDANT_IMPORT with UNUSED_IMPORTS
fabric-and-ink Mar 17, 2019
aac7295
Fix tests
fabric-and-ink Mar 17, 2019
0ddd6b9
Add glob import to redundancy test
fabric-and-ink Mar 17, 2019
98b2672
update mailmap for Bastian Kauschke
lcnr Mar 17, 2019
dad4a67
Fix more tests
fabric-and-ink Mar 17, 2019
4b09e98
Fix doc tests
fabric-and-ink Mar 17, 2019
ab2522a
Change message to present tense
fabric-and-ink Mar 17, 2019
9d408d9
Add todo!() macro
matklad Nov 29, 2018
87e727a
Handle glob import in redundancy check
fabric-and-ink Mar 18, 2019
caa37d8
Restore test
fabric-and-ink Mar 18, 2019
de4be2c
Stabilize refcell_map_split feature
joshlf Mar 18, 2019
baf7c42
Rollup merge of #56348 - matklad:todo-macro, r=withoutboats
Centril Mar 19, 2019
8ddcc75
Rollup merge of #57729 - pnkfelix:issue-55748-pat-types-are-constrain…
Centril Mar 19, 2019
1dce36e
Rollup merge of #57847 - clarcharr:dbg_no_params, r=Centril
Centril Mar 19, 2019
8881504
Rollup merge of #58805 - fabric-and-ink:redundant_import, r=petrochenkov
Centril Mar 19, 2019
4eeaad2
Rollup merge of #58812 - jonhoo:floor_v_trunc, r=alexcrichton
Centril Mar 19, 2019
dab16d9
Rollup merge of #58913 - Milack27:patch_buf_reader, r=joshtriplett
Centril Mar 19, 2019
6c8d63b
Rollup merge of #58927 - GuillaumeGomez:default-keyword, r=QuietMisdr…
Centril Mar 19, 2019
fce8f7c
Rollup merge of #58939 - taeguk:fix-doc-about-pin, r=rkruppe
Centril Mar 19, 2019
be840cd
Rollup merge of #59106 - LinusU:udp-peer-addr, r=kennytm
Centril Mar 19, 2019
baa344b
Rollup merge of #59116 - estebank:comma-sugg, r=petrochenkov
Centril Mar 19, 2019
3663ee4
Rollup merge of #59252 - lcnr:mailmap, r=Centril
Centril Mar 19, 2019
631534c
Rollup merge of #59280 - joshlf:sandbox/joshlf/stabilize-refcell-map-…
Centril Mar 19, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change message to present tense
fabric-and-ink committed Mar 17, 2019
commit ab2522a10e64a25d4886e31540def37fb789f601
2 changes: 1 addition & 1 deletion src/librustc/lint/builtin.rs
Original file line number Diff line number Diff line change
@@ -584,7 +584,7 @@ impl BuiltinLintDiagnostics {
let introduced = if is_imported { "imported" } else { "defined" };
db.span_label(
span,
format!("the item `{}` was already {} here", ident, introduced)
format!("the item `{}` is already {} here", ident, introduced)
);
}
}
4 changes: 2 additions & 2 deletions src/test/ui/lint/lint-unused-imports.stderr
Original file line number Diff line number Diff line change
@@ -45,7 +45,7 @@ LL | | fn f() {
LL | | self::g();
LL | | }
LL | | }
| |_- the item `g` was already defined here
| |_- the item `g` is already defined here

error: unused import: `self::g`
--> $DIR/lint-unused-imports.rs:68:9
@@ -57,7 +57,7 @@ error: the item `foo` is imported redundantly
--> $DIR/lint-unused-imports.rs:78:9
|
LL | use test2::{foo, bar};
| --- the item `foo` was already imported here
| --- the item `foo` is already imported here
...
LL | use test2::foo;
| ^^^^^^^^^^
4 changes: 2 additions & 2 deletions src/test/ui/lint/use-redundant.stderr
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ warning: the item `Bar` is imported redundantly
--> $DIR/use-redundant.rs:21:9
|
LL | use crate::foo::Bar;
| --------------- the item `Bar` was already imported here
| --------------- the item `Bar` is already imported here
...
LL | use crate::foo::Bar;
| ^^^^^^^^^^^^^^^
@@ -29,7 +29,7 @@ warning: the item `S` is imported redundantly
--> $DIR/use-redundant.rs:25:9
|
LL | use m1::*;
| ----- the item `S` was already imported here
| ----- the item `S` is already imported here
...
LL | use m1::S;
| ^^^^^