Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use references for variances_of #60287

Merged
merged 2 commits into from
May 1, 2019
Merged

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Apr 25, 2019

Based on #60280.

cc @varkor
r? @eddyb

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2019
@eddyb
Copy link
Member

eddyb commented Apr 30, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Apr 30, 2019

📌 Commit d2ff829 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 30, 2019
Centril added a commit to Centril/rust that referenced this pull request May 1, 2019
@bors
Copy link
Contributor

bors commented May 1, 2019

⌛ Testing commit d2ff829 with merge c511260853ebc5840ae79384c23678cda749c62c...

@Centril
Copy link
Contributor

Centril commented May 1, 2019

@bors retry

@Centril Centril closed this May 1, 2019
@Centril Centril reopened this May 1, 2019
@Centril
Copy link
Contributor

Centril commented May 1, 2019

@bors r=eddyb retry

@bors
Copy link
Contributor

bors commented May 1, 2019

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented May 1, 2019

📌 Commit d2ff829 has been approved by eddyb

@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Checking out files: 100% (17945/17945), done.
travis_time:end:0bcc4006:start=1556691155506442000,finish=1556691164695427000,duration=9188985000
$ cd rust-lang/rust
$ git checkout -qf c511260853ebc5840ae79384c23678cda749c62c
fatal: reference is not a tree: c511260853ebc5840ae79384c23678cda749c62c
The command "git checkout -qf c511260853ebc5840ae79384c23678cda749c62c" failed and exited with 128 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Centril added a commit to Centril/rust that referenced this pull request May 1, 2019
bors added a commit that referenced this pull request May 1, 2019
Rollup of 7 pull requests

Successful merges:

 - #60287 (Use references for variances_of)
 - #60327 (Search for incompatible universes in borrow errors)
 - #60330 (Suggest using an inclusive range instead of an exclusive range when the endpoint overflows by 1)
 - #60366 (build-gcc: Create missing cc symlink)
 - #60369 (Support ZSTs in DispatchFromDyn)
 - #60404 (Implement `BorrowMut<str>` for `String`)
 - #60417 (Rename hir::ExprKind::Use to ::DropTemps and improve docs.)

Failed merges:

r? @ghost
@bors bors merged commit d2ff829 into rust-lang:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants