Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug preventing const parameters from being used in const generic impls #60717

Merged
merged 2 commits into from
May 11, 2019
Merged

Fix a bug preventing const parameters from being used in const generic impls #60717

merged 2 commits into from
May 11, 2019
+34 −1

Conversation

varkor
Copy link
Member

@varkor varkor commented May 10, 2019

Fixes #60712.

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2019
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 11, 2019

📌 Commit b3207d5 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2019
@bors
Copy link
Contributor

bors commented May 11, 2019

⌛ Testing commit b3207d5 with merge af39a1f...

bors added a commit that referenced this pull request May 11, 2019
@bors
Auto merge of #60717 - varkor:impl-const-generic, r=matthewjasper
af39a1f 
Fix a bug preventing const parameters from being used in const generic impls

Fixes #60712.
@varkor varkor mentioned this pull request May 11, 2019
Closed
@bors
Copy link
Contributor

bors commented May 11, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: matthewjasper
Pushing af39a1f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 11, 2019
@bors bors merged commit b3207d5 into rust-lang:master May 11, 2019
@varkor varkor deleted the impl-const-generic branch May 11, 2019 12:33
@varkor varkor added the F-const_generics `#![feature(const_generics)]` label Oct 19, 2019
@varkor varkor mentioned this pull request Oct 19, 2019
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewjasper matthewjasper

Labels
F-const_generics `#![feature(const_generics)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spurious unconstrained const parameter warning in impl
4 participants
@varkor @rust-highfive @matthewjasper @bors