Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 3 pull requests #61154

Closed
wants to merge 81 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
e349f8f
Use a PathBuf instead of String for representing the pgo-use path int…
michaelwoerister May 22, 2019
01a59a3
PGO: Check that pgo-use file actually exists. LLVM seems to only emit…
michaelwoerister May 22, 2019
b1f27fa
rustbuild: Also build compiler-rt when building LLDB. This allows cla…
michaelwoerister May 22, 2019
51463d0
Add a smoketest for combining PGO with xLTO.
michaelwoerister May 20, 2019
b3c5cdd
Fix unit test after pgo-use change.
michaelwoerister May 22, 2019
1a35a1c
Ship profiler with windows-gnu
mati865 May 23, 2019
2e39b9c
Make find_local iterate instead of recurse
spastorino May 23, 2019
d5e0353
Update cargo
ehuss May 23, 2019
46ffb6a
tidy: don't short-circuit on license error
ehuss May 23, 2019
45e9d8e
Avoid interning in `resolve_place_op`.
nnethercote May 22, 2019
f9c4a90
Avoid unnecessary internings.
nnethercote May 22, 2019
2fab5d6
Pass symbols to `ExtCtxt::std_path` instead of strings.
nnethercote May 22, 2019
c040b3b
Pre-intern "0", "1", ..., "9", and use where appropriate.
nnethercote May 22, 2019
eb962c2
Add `ty_to_symbol` methods.
nnethercote May 23, 2019
babd1a1
Avoid some re-interning in `to_lit_token`.
nnethercote May 23, 2019
54c8725
Use `Symbol` equality in `is_ident_named`.
nnethercote May 23, 2019
c389116
Use `Symbol` equality in `check_ident_token`.
nnethercote May 23, 2019
71920d3
Use `Symbol` equality in `may_begin_with` and `parse_nt`.
nnethercote May 23, 2019
d3c73dd
typo
blkerby May 19, 2019
0123fab
Fix typo "spit_paths", add link
blkerby May 24, 2019
fbc6a4b
Revert edition-guide toolstate override
ehuss May 24, 2019
9be8b7e
Fixed type-alias-bounds lint doc
Cerber-Ursi May 24, 2019
a8fc09b
Use FnOnce instead of FnBox in libtest
SimonSapin May 24, 2019
67ee286
Remove the incorrect warning from README.md
scottmcm May 24, 2019
73fd349
Deprecate `FnBox`. `Box<dyn FnOnce()>` can be called directly, since …
SimonSapin May 24, 2019
6d14e73
Changes the type `mir::Mir` into `mir::Body`
May 17, 2019
e396f99
Don't arena-allocate static symbols.
nnethercote May 23, 2019
698e50f
Delay ICE in fold_region so feature gate has chance to stop compilati…
pnkfelix May 24, 2019
8e4132a
Delay ICE in early_free_scope so feature gate has chance to stop comp…
pnkfelix May 24, 2019
c235ba4
Regression test for issue #60654.
pnkfelix May 24, 2019
d01ef7d
improve debug-printing of scalars
RalfJung May 24, 2019
a90cdcc
this is for tidy
RalfJung May 24, 2019
34314ca
Make find iterate instead of recurse
spastorino May 23, 2019
03dc30d
Make sanitize_place iterate instead of recurse
spastorino May 23, 2019
aba152d
Updated my mailmap entry
XAMPPRocky May 24, 2019
9613779
Make borrow_of_local_data iterate instead of recurse
spastorino May 23, 2019
10fe269
Make ignore_borrow iterate instead of recurse
spastorino May 23, 2019
2416017
Tweak macro parse errors when reaching EOF during macro call parse
estebank May 22, 2019
5c5fa77
review comments
estebank May 22, 2019
a2f853a
Fix rebase
estebank May 22, 2019
da57ac3
Move diagnostic logic out of parser
estebank May 22, 2019
8173feb
Avoid catch-all arm, use Base(PlaceBase::Static(_))
spastorino May 24, 2019
035f651
Annotate each `reverse_bits` with `#[must_use]`
nvzqz May 24, 2019
59762ba
Move async/await tests to test/ui/async-await
varkor May 24, 2019
d289a5b
Move some issues into the issues folder
varkor May 24, 2019
df26dd8
Add auxiliary issue file
varkor May 24, 2019
06b8570
Add drop-order folder in test/ui/async-await
varkor May 24, 2019
cb7e0d0
Add issues folder in async-await
varkor May 24, 2019
aea0400
Move error code tests to error code folder
varkor May 24, 2019
79816bb
Delete stray .stderr
varkor May 24, 2019
6d7a362
Make eval_place_to_mplace take PlaceBase::Static
spastorino May 24, 2019
e38b399
Make eval_place_to_op iterate instead of recurse
spastorino May 23, 2019
ee7593e
Revert changes that belong to separate PR
estebank May 24, 2019
c91ab64
Add extra arc_wake
varkor May 24, 2019
519b040
Rollup merge of #61026 - estebank:macro-eof-spans, r=petrochenkov
Centril May 25, 2019
2ac8ec0
Rollup merge of #61095 - ehuss:update-cargo, r=alexcrichton
Centril May 25, 2019
835281f
Rollup merge of #61096 - ehuss:tidy-license-short-circuit, r=Centril
Centril May 25, 2019
77afe6a
Rollup merge of #61107 - blkerby:docs_typos, r=Centril
Centril May 25, 2019
f8b3ebe
Rollup merge of #61110 - ehuss:revert-edition-override, r=Mark-Simula…
Centril May 25, 2019
65ddf28
Rollup merge of #61111 - Cerberuser:patch-1, r=steveklabnik
Centril May 25, 2019
8e5e1a0
Rollup merge of #61113 - SimonSapin:fnbox, r=alexcrichton
Centril May 25, 2019
56e77b7
Rollup merge of #61116 - scottmcm:vcpp-download-link, r=alexcrichton
Centril May 25, 2019
57139e2
Rollup merge of #61118 - pnkfelix:issue-60654-dont-ice-on-gat, r=varkor
Centril May 25, 2019
deaacaf
Rollup merge of #61121 - RalfJung:miri-value-printing, r=oli-obk
Centril May 25, 2019
98052b0
Rollup merge of #61125 - XAMPPRocky:master, r=jonas-schievink
Centril May 25, 2019
92f1cfd
Rollup merge of #61134 - nvzqz:reverse_bits-must_use, r=varkor
Centril May 25, 2019
19b5a10
Rollup merge of #61138 - varkor:async-await-tests, r=cramertj
Centril May 25, 2019
1ce0288
Rollup merge of #61092 - spastorino:sanitize-place-iterative, r=oli-obk
Centril May 25, 2019
b4f6e5b
Rollup merge of #61093 - spastorino:borrow-of-local-data-iterate, r=o…
Centril May 25, 2019
af01552
Rollup merge of #61094 - spastorino:find-local-iterate, r=oli-obk
Centril May 25, 2019
e30300d
Rollup merge of #61099 - spastorino:ignore-borrow-iterate, r=oli-obk
Centril May 25, 2019
dd33e8a
Rollup merge of #61103 - spastorino:find-iterate, r=oli-obk
Centril May 25, 2019
1cd3ddd
Rollup merge of #61104 - spastorino:eval-place-to-op-iterate, r=oli-obk
Centril May 25, 2019
238d621
Rollup merge of #60928 - TheSirC:fix/60229, r=eddyb
Centril May 25, 2019
3aec262
Rollup merge of #61035 - nnethercote:avoid-more-symbol-interning, r=p…
Centril May 25, 2019
99b7890
Rollup merge of #61036 - michaelwoerister:pgo-xlto-test, r=alexcrichton
Centril May 25, 2019
ebd6c31
Rollup merge of #61077 - nnethercote:tweak-prefill, r=petrochenkov
Centril May 25, 2019
c907f03
Rollup merge of #61080 - mati865:mingw_pgo, r=sanxiyn
Centril May 25, 2019
fd8a334
Rollup merge of #61150 - Centril:rollup-wmm7qga, r=Centril
Centril May 25, 2019
cc3d058
Rollup merge of #61151 - Centril:rollup-5rpyhfo, r=Centril
Centril May 25, 2019
400d0df
Rollup merge of #61153 - Centril:rollup-b9qpiez, r=Centril
Centril May 25, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid interning in resolve_place_op.
This function is hot for `keccak`.
  • Loading branch information
nnethercote committed May 23, 2019
commit 45e9d8e1dca2372a7874740f6af8aaa09f7b1c4b
14 changes: 5 additions & 9 deletions src/librustc_typeck/check/mod.rs
Original file line number Diff line number Diff line change
@@ -2698,16 +2698,12 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {

fn resolve_place_op(&self, op: PlaceOp, is_mut: bool) -> (Option<DefId>, ast::Ident) {
let (tr, name) = match (op, is_mut) {
(PlaceOp::Deref, false) =>
(self.tcx.lang_items().deref_trait(), "deref"),
(PlaceOp::Deref, true) =>
(self.tcx.lang_items().deref_mut_trait(), "deref_mut"),
(PlaceOp::Index, false) =>
(self.tcx.lang_items().index_trait(), "index"),
(PlaceOp::Index, true) =>
(self.tcx.lang_items().index_mut_trait(), "index_mut"),
(PlaceOp::Deref, false) => (self.tcx.lang_items().deref_trait(), sym::deref),
(PlaceOp::Deref, true) => (self.tcx.lang_items().deref_mut_trait(), sym::deref_mut),
(PlaceOp::Index, false) => (self.tcx.lang_items().index_trait(), sym::index),
(PlaceOp::Index, true) => (self.tcx.lang_items().index_mut_trait(), sym::index_mut),
};
(tr, ast::Ident::from_str(name))
(tr, ast::Ident::with_empty_ctxt(name))
}

fn try_overloaded_place_op(&self,
4 changes: 4 additions & 0 deletions src/libsyntax_pos/symbol.rs
Original file line number Diff line number Diff line change
@@ -204,6 +204,8 @@ symbols! {
default_type_params,
deny,
deprecated,
deref,
deref_mut,
derive,
doc,
doc_alias,
@@ -291,6 +293,8 @@ symbols! {
impl_header_lifetime_elision,
impl_trait_in_bindings,
import_shadowing,
index,
index_mut,
in_band_lifetimes,
include,
inclusive_range_syntax,