Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Symbolic variant to Operand #62197

Closed
wants to merge 1 commit into from
Closed

Add Symbolic variant to Operand #62197

wants to merge 1 commit into from

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Jun 28, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2019
@RalfJung
Copy link
Member

This seems reasonable but not very useful on its own?

If you add the associated type to the Machine, you at least have a place to also put some docs about the purpose of this. It'll also become a much bigger patch though. Better do it after Tuesday (that's when Miri is allowed to break again), and after #62173 lands.

Still, I am not sure about landing something that is entirely useless on its own.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2019
@joelpalmer
Copy link

Ping from Triage: @oli-obk are there any updates on this PR?

@Dylan-DPC-zz
Copy link

r? @RalfJung

@christianpoveda any updates on this ?

@rust-highfive rust-highfive assigned RalfJung and unassigned oli-obk Jul 22, 2019
@RalfJung
Copy link
Member

RalfJung commented Jul 22, 2019 •
edited
Loading

I think Oli is the better reviewer for this, they made some plans on Zulip with @christianpoveda, so I am going to assign them again.

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned RalfJung Jul 22, 2019
@JohnTitor
Copy link
Member

Ping from triage: any updates? @christianpoveda @oli-obk

@pvdrz
Copy link
Contributor Author

pvdrz commented Jul 29, 2019

I believe I am closing this for now. This is not a priority and we can always come back to it later

@pvdrz pvdrz closed this Jul 29, 2019
@pvdrz pvdrz deleted the symbolic-execution branch July 29, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pvdrz @RalfJung @joelpalmer @Dylan-DPC-zz @JohnTitor @oli-obk @Mark-Simulacrum @rust-highfive