Add default serialization for Idents
#63853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
matthewjasper
force-pushed
the
test-ast-serialization
branch
from
9cb7414 to
0bde766
Compare
|
@bors r+ |
|
📌 Commit 0bde766 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 27, 2019
…n, r=estebank Add default serialization for `Ident`s Also add tests for `-Zast-json` and `-Zast-json-noexpand` closes rust-lang#63728
|
Failed in #63936 (comment), @bors r- |
bors
added
S-waiting-on-author
Add tests for -Zast-json and -Zast-json-noexpand, which need this impl.
matthewjasper
force-pushed
the
test-ast-serialization
branch
from
0bde766 to
3d71803
Compare
|
@bors r=estebank |
|
📌 Commit 3d71803 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 28, 2019
Add default serialization for `Ident`s Also add tests for `-Zast-json` and `-Zast-json-noexpand` closes #63728
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add tests for
-Zast-jsonand-Zast-json-noexpandcloses #63728