-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a failing UI test for multiple loops of all kinds in a const
#66096
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
const _: i32 = { | ||
let mut x = 0; | ||
|
||
while x < 4 { | ||
//~^ ERROR constant contains unimplemented expression type | ||
//~| ERROR constant contains unimplemented expression type | ||
x += 1; | ||
} | ||
|
||
while x < 8 { | ||
x += 1; | ||
} | ||
|
||
x | ||
}; | ||
|
||
const _: i32 = { | ||
let mut x = 0; | ||
|
||
for i in 0..4 { | ||
//~^ ERROR constant contains unimplemented expression type | ||
//~| ERROR constant contains unimplemented expression type | ||
//~| ERROR references in constants may only refer to immutable values | ||
//~| ERROR calls in constants are limited to constant functions, tuple | ||
// structs and tuple variants | ||
x += i; | ||
} | ||
|
||
for i in 0..4 { | ||
x += i; | ||
} | ||
|
||
x | ||
}; | ||
|
||
const _: i32 = { | ||
let mut x = 0; | ||
|
||
loop { | ||
x += 1; | ||
if x == 4 { | ||
//~^ ERROR constant contains unimplemented expression type | ||
//~| ERROR constant contains unimplemented expression type | ||
break; | ||
} | ||
} | ||
|
||
loop { | ||
x += 1; | ||
if x == 8 { | ||
break; | ||
} | ||
} | ||
|
||
x | ||
}; | ||
|
||
fn main() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
error[E0019]: constant contains unimplemented expression type | ||
--> $DIR/const-loop.rs:4:11 | ||
| | ||
LL | while x < 4 { | ||
| ^^^^^ | ||
|
||
error[E0019]: constant contains unimplemented expression type | ||
--> $DIR/const-loop.rs:4:5 | ||
| | ||
LL | / while x < 4 { | ||
LL | | | ||
LL | | | ||
LL | | x += 1; | ||
LL | | } | ||
| |_____^ | ||
|
||
error[E0015]: calls in constants are limited to constant functions, tuple structs and tuple variants | ||
--> $DIR/const-loop.rs:20:14 | ||
| | ||
LL | for i in 0..4 { | ||
| ^^^^ | ||
|
||
error[E0019]: constant contains unimplemented expression type | ||
--> $DIR/const-loop.rs:20:14 | ||
| | ||
LL | for i in 0..4 { | ||
| ^^^^ | ||
|
||
error[E0017]: references in constants may only refer to immutable values | ||
--> $DIR/const-loop.rs:20:14 | ||
| | ||
LL | for i in 0..4 { | ||
| ^^^^ constants require immutable values | ||
|
||
error[E0019]: constant contains unimplemented expression type | ||
--> $DIR/const-loop.rs:20:9 | ||
| | ||
LL | for i in 0..4 { | ||
| ^ | ||
|
||
error[E0019]: constant contains unimplemented expression type | ||
--> $DIR/const-loop.rs:41:12 | ||
| | ||
LL | if x == 4 { | ||
| ^^^^^^ | ||
|
||
error[E0019]: constant contains unimplemented expression type | ||
--> $DIR/const-loop.rs:41:9 | ||
| | ||
LL | / if x == 4 { | ||
LL | | | ||
LL | | | ||
LL | | break; | ||
LL | | } | ||
| |_________^ | ||
|
||
error: aborting due to 8 previous errors | ||
|
||
Some errors have detailed explanations: E0015, E0017, E0019. | ||
For more information about an error, try `rustc --explain E0015`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the checker stop before reaching here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The current one does. The new one can give much better errors on code like this but enabling it is blocked on #65949.
For background, I was using this file as a test case while working on improving diagnostics for the new checker, and figured it could be merged upstream separately.