Un-stabilize --extern-private option in rustdoc

[GuillaumeGomez]

Part of #66211

cc @kinnison
r? @ollie27

[jonas-schievink]

Duplicate of #66655

[rust-highfive]

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-23T12:11:00.8747830Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-23T12:11:00.8937394Z ##[command]git config gc.auto 0
2019-11-23T12:11:00.9003824Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-23T12:11:00.9073495Z ##[command]git config --get-all http.proxy
2019-11-23T12:11:00.9210965Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66666/merge:refs/remotes/pull/66666/merge
---
2019-11-23T13:06:42.6867479Z .................................................................................................... 1600/9280
2019-11-23T13:06:47.2790892Z .................................................................................................... 1700/9280
2019-11-23T13:06:59.6372508Z ...........................i........................................................................ 1800/9280
2019-11-23T13:07:05.9525729Z .................................................................................................... 1900/9280
2019-11-23T13:07:19.2626097Z ............iiiii................................................................................... 2000/9280
2019-11-23T13:07:28.2585558Z .................................................................................................... 2200/9280
2019-11-23T13:07:30.6182257Z .................................................................................................... 2300/9280
2019-11-23T13:07:35.6801908Z .................................................................................................... 2400/9280
2019-11-23T13:07:55.6952043Z .................................................................................................... 2500/9280
---
2019-11-23T13:10:28.6006294Z ............i...............i....................................................................... 4800/9280
2019-11-23T13:10:38.2223482Z .................................................................................................... 4900/9280
2019-11-23T13:10:44.3422842Z .................................................................................................... 5000/9280
2019-11-23T13:10:52.6459039Z .................................................................................................... 5100/9280
2019-11-23T13:10:58.4462937Z .................ii.ii...........i.................................................................. 5200/9280
2019-11-23T13:11:07.2431349Z .................................................................................................... 5400/9280
2019-11-23T13:11:17.7617362Z ...................................................................................................i 5500/9280
2019-11-23T13:11:25.1357115Z .................................................................................................... 5600/9280
2019-11-23T13:11:30.5041244Z .................................................................................................... 5700/9280
2019-11-23T13:11:30.5041244Z .................................................................................................... 5700/9280
2019-11-23T13:11:40.3194364Z .....................................................................................ii...i..ii..... 5800/9280
2019-11-23T13:12:02.1170071Z .................................................................................................... 6000/9280
2019-11-23T13:12:09.7047125Z .................................................................................................... 6100/9280
2019-11-23T13:12:16.3617855Z .................................................................................................... 6200/9280
2019-11-23T13:12:16.3617855Z .................................................................................................... 6200/9280
2019-11-23T13:12:28.8095645Z ........i..ii....................................................................................... 6300/9280
2019-11-23T13:12:46.9857542Z ............................................................................i....................... 6500/9280
2019-11-23T13:12:49.2234540Z .................................................................................................... 6600/9280
2019-11-23T13:12:51.3270483Z ...................................................................i................................ 6700/9280
2019-11-23T13:12:54.0991072Z .................................................................................................... 6800/9280
---
2019-11-23T13:14:28.2336689Z .................................................................................................... 7400/9280
2019-11-23T13:14:33.3099081Z .................................................................................................... 7500/9280
2019-11-23T13:14:41.4223462Z .................................................................................................... 7600/9280
2019-11-23T13:14:51.8714972Z .................................................................................................... 7700/9280
2019-11-23T13:14:59.8976438Z ................................................................................................ii.. 7800/9280
2019-11-23T13:15:11.4024479Z .................................................................................................... 8000/9280
2019-11-23T13:15:25.5433741Z .................................................................................................... 8100/9280
2019-11-23T13:15:33.5820161Z .................................................................................................... 8200/9280
2019-11-23T13:15:41.4151114Z .................................................................................................... 8300/9280
---
2019-11-23T13:17:47.1059125Z  finished in 5.535
2019-11-23T13:17:47.1237996Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-23T13:17:47.2971070Z 
2019-11-23T13:17:47.2972708Z running 157 tests
2019-11-23T13:17:50.0992221Z iiii....iii......iii..iiii...i.............................i..i..................i....i...........ii 100/157
2019-11-23T13:17:51.9525941Z .i.i..iiii..............i.........iii.i..........ii......
2019-11-23T13:17:51.9530033Z 
2019-11-23T13:17:51.9530120Z  finished in 4.829
2019-11-23T13:17:51.9709269Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-23T13:17:52.1258007Z 
---
2019-11-23T13:17:54.0072764Z  finished in 2.036
2019-11-23T13:17:54.0245842Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-23T13:17:54.1711058Z 
2019-11-23T13:17:54.1711668Z running 9 tests
2019-11-23T13:17:54.1714895Z iiiiiiiii
2019-11-23T13:17:54.1715603Z 
2019-11-23T13:17:54.1715649Z  finished in 0.146
2019-11-23T13:17:54.1895197Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-23T13:17:54.3602376Z 
---
2019-11-23T13:18:12.7217266Z  finished in 18.532
2019-11-23T13:18:12.7411740Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-23T13:18:12.9069924Z 
2019-11-23T13:18:12.9070857Z running 124 tests
2019-11-23T13:18:36.4523581Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i....ii...i.......ii 100/124
2019-11-23T13:18:41.3036811Z .i.i.i......iii.i.....ii
2019-11-23T13:18:41.3037275Z 
2019-11-23T13:18:41.3037315Z  finished in 28.562
2019-11-23T13:18:41.3048132Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-23T13:18:41.3048524Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-11-23T13:24:53.6937744Z ---- [rustdoc] rustdoc/issue-66159.rs stdout ----
2019-11-23T13:24:53.6937772Z 
2019-11-23T13:24:53.6937839Z error: rustdoc failed!
2019-11-23T13:24:53.6937875Z status: exit code: 1
2019-11-23T13:24:53.6938448Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/issue-66159/auxiliary" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/issue-66159" "/checkout/src/test/rustdoc/issue-66159.rs" "--extern-private" "issue_66159_1=/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/issue-66159/auxiliary/libissue_66159_1.so"
2019-11-23T13:24:53.6938710Z ------------------------------------------
2019-11-23T13:24:53.6938736Z 
2019-11-23T13:24:53.6939061Z ------------------------------------------
2019-11-23T13:24:53.6939110Z stderr:
---
2019-11-23T13:24:53.6940390Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-11-23T13:24:53.6940432Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-11-23T13:24:53.6940471Z 
2019-11-23T13:24:53.6940489Z 
2019-11-23T13:24:53.6946607Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/rustdoc" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "rustdoc" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-11-23T13:24:53.6946879Z 
2019-11-23T13:24:53.6947004Z 
2019-11-23T13:24:53.6951273Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-11-23T13:24:53.6951344Z Build completed unsuccessfully in 1:07:57
2019-11-23T13:24:53.6951344Z Build completed unsuccessfully in 1:07:57
2019-11-23T13:24:53.7000611Z == clock drift check ==
2019-11-23T13:24:53.7013251Z   local time: Sat Nov 23 13:24:53 UTC 2019
2019-11-23T13:24:53.9794679Z   network time: Sat, 23 Nov 2019 13:24:53 GMT
2019-11-23T13:24:53.9798620Z == end clock drift check ==
2019-11-23T13:24:56.1232395Z 
2019-11-23T13:24:56.1346173Z ##[error]Bash exited with code '1'.
2019-11-23T13:24:56.1410893Z ##[section]Starting: Checkout
2019-11-23T13:24:56.1413609Z ==============================================================================
2019-11-23T13:24:56.1413685Z Task         : Get sources
2019-11-23T13:24:56.1413735Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[GuillaumeGomez]

@jonas-schievink Indeed. But our codes diverge a bit... I wonder if my extra change is actually useful... cc @ollie27

[GuillaumeGomez]

No it's not, closing then!

[Dylan-DPC-zz]

@GuillaumeGomez you ruined #66666 😂

[GuillaumeGomez]

Such a shame! 😈