Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement unused_parens for trailing return value #68478

Closed
wants to merge 7 commits into from
Closed

Implement unused_parens for trailing return value #68478

wants to merge 7 commits into from

Conversation

Tyg13
Copy link
Contributor

@Tyg13 Tyg13 commented Jan 23, 2020

Fixes #68386

r? @varkor

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @varkor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 23, 2020
Centril
Centril approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with the second merge commit squashed into the first.

@Centril
Copy link
Contributor

Centril commented Jan 23, 2020

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned varkor Jan 23, 2020
@Tyg13
Copy link
Contributor Author

Tyg13 commented Jan 23, 2020

Apologies, I seem to have seriously messed up my git-fu somewhere

@Tyg13
Copy link
Contributor Author

Tyg13 commented Jan 23, 2020

I think I'll just re-open the PR. Seems cleaner that way

@Tyg13 Tyg13 closed this Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril approved these changes

Assignees

@Centril Centril

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unused_parens doesn't fire for trailing return expression
6 participants
@Tyg13 @rust-highfive @Centril @varkor @ehuss @JohnTitor