-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiletest: Unit tests for EarlyProps
(+ small cleanup)
#68533
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests?? Unheard of. I love it.
@bors r+ |
📌 Commit 3a85fbcb709b6a88c7a2e0d00837af75b67f166e has been approved by |
⌛ Testing commit 3a85fbcb709b6a88c7a2e0d00837af75b67f166e with merge b9200b373f56005b2765382349516e7b32257cd8... |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
💔 Test failed - checks-azure |
Replace `BufRead::lines` with `BuRead::read_line` to reduce memory allocations.
Reordered file opening with is a directory check to avoid error on Windows. Unfortunately I had to change the indentation. |
@bors r+ |
📌 Commit 3c02afe has been approved by |
compiletest: Unit tests for `EarlyProps` (+ small cleanup) * Parse `EarlyProps` from a reader * Add unit tests for `EarlyProps` * Remove unused `llvm-cxxflags` option * Remove unnecessary memory allocations in `iter_header` * Update mode list displayed in `--help`
☀️ Test successful - checks-azure |
EarlyProps
from a readerEarlyProps
llvm-cxxflags
optioniter_header
--help