-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
submodules: update cargo #68823
submodules: update cargo #68823
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @ehuss I'd like to get rust-lang/cargo#7768 into nightly. |
@bors r+ |
📌 Commit faa4ada6142302939adf6d29a1f47a608fde409d has been approved by |
faa4ada
to
738eee0
Compare
I've added a rls update to make sure the PR does not break rls toolstate. |
@rustbot modify labels to +S-waiting-on-review, -S-waiting-on-bors |
📌 Commit 738eee082127dc3a592360e0739346e3295851b6 has been approved by |
738eee0
to
c8bfbd8
Compare
I've updated rls and cargo submodules again since looking at the queue, this is not going to merge very soon, and some more PRs/fixes were merged upstream... |
I guess I could update clippy as well while i'm at it, since it was just fixed... |
@bors p=1 |
@rustbot modify labels to +S-waiting-on-review, -S-waiting-on-bors |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
I added the dep to the list. |
@rustbot modify labels to +S-waiting-on-review, -S-waiting-on-bors |
I would prefer to not roll up clippy and cargo together. Can you separate them into different PRs? |
I could be wrong (@topecongiro and @Xanewok would know definitively), but I think that the updates for rustfmt and rls need to be coordinated since they both have rustc-ap-* crates within their dependency trees, and I believe the versions of those crates need to be kept in sync. Rls currently has v610 (transitively via Racer) but rustfmt is, as of yesterday, on v642. I believe that v1.4.12 of the rustfmt lib needs to be published to crates.io and that Racer needs to be updated to v642 before the updates can be made in Rls |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
b04d6e9
to
451d492
Compare
I removed everything but cargo again. |
@bors r+ |
📌 Commit 451d492 has been approved by |
⌛ Testing commit 451d492 with merge e70b4fcd104e9936544b1a147b1de4caa7af69fe... |
💔 Test failed - checks-azure |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
looks spurious
|
Possibly #55861 |
☀️ Test successful - checks-azure |
No description provided.